Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share jail capability? #3615

Closed
kulmann opened this issue Apr 28, 2022 · 4 comments · Fixed by #3626
Closed

Share jail capability? #3615

kulmann opened this issue Apr 28, 2022 · 4 comments · Fixed by #3626

Comments

@kulmann
Copy link
Member

kulmann commented Apr 28, 2022

Is your feature request related to a problem? Please describe.

In owncloud/web#6593 we'll switch over to a) the personal space dav endpoint and b) share jail dav endpoints for all shares (personal space doesn't have shares mounted into a Shares folder anymore). Existing customers need some more time to migrate to spaces, making the old webdav v2 user home unavailable in the web ui is not an option.

Describe the solution you'd like

More fine grained spaces sub-capabilities. At the moment, the spaces capability looks like this:

spaces: {
  enabled: true,
  version: "0.0.1"
}

I'd like to propose feature flags in that struct, e.g.

spaces: {
  enabled: true,
  version: "0.0.1",
  projects: true,
  share_jail: true
}

This way someone could decide to try out the new project spaces but still keep the old webdav homes for the moment.
Open for discussion about solution in general and naming of the sub-capabilities.

Describe alternatives you've considered

Fully relying on the spaces.enabled capability only, but that would mean that trying out our quite rich project spaces feature set is not possible if the share jail is not compatible with the rest of your system at the moment.

Additional context

@micbar
Copy link
Contributor

micbar commented Apr 28, 2022

I am in favour of that proposal. If it makes the feature handling in web easier, we should just do it.

@C0rby
Copy link
Contributor

C0rby commented Apr 28, 2022

Yeah, I don't see anything against it. 👍

@kulmann
Copy link
Member Author

kulmann commented May 16, 2022

cc @felix-schwarz @michaelstingl @TheOneRing @jesmrec @hosy
oCIS 2.0.0-beta1 has more specific spaces related capabilities than a few weeks ago. You can use the spaces.projects feature flag for checking if the project spaces feature is enabled/desired. Similar for spaces.share_jail to check if the respective client should use the "personal space + share jail" or old webdav v2 user home (for a user home with mounted shares).

@TheOneRing
Copy link
Member

The desktop client only supports spaces + share jail or no spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants