Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces capability feature flags #3626

Merged
merged 1 commit into from
May 2, 2022
Merged

Spaces capability feature flags #3626

merged 1 commit into from
May 2, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Apr 29, 2022 •
edited

Description

Adds new share_jail and projects feature flags to the spaces capability.

Related Issue

Motivation and Context

Provide a switch to indicate to clients to still use the old user home webdav endpoint.

How Has This Been Tested?

just in CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs

This comment was marked as resolved.

Sign in to view
@kulmann kulmann mentioned this pull request Apr 29, 2022
Merged
30 tasks
@ownclouders
Copy link
Contributor

ownclouders commented Apr 29, 2022 •
edited

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@micbar micbar mentioned this pull request Apr 29, 2022
Closed
45 tasks
@kulmann kulmann force-pushed the spaces-capability-feature-flags branch 3 times, most recently from 78fe5c6 to f7d8287 Compare May 2, 2022 10:03
@kulmann kulmann force-pushed the spaces-capability-feature-flags branch from f7d8287 to 1c5bfac Compare May 2, 2022 10:07
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit 40d5f95 into master May 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-capability-feature-flags branch May 2, 2022 10:59
ownclouders pushed a commit that referenced this pull request May 2, 2022
@kulmann
commit 40d5f95
52471bb 
Merge: d8e84db 1c5bfac
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Mon May 2 12:59:53 2022 +0200

    Merge pull request #3626 from owncloud/spaces-capability-feature-flags

    Spaces capability feature flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share jail capability?
3 participants
@kulmann @ownclouders @butonic