[ocis] Remove a group from the space

[exalate-issue-sync]

Description

User Stories

• As a space manager, i want to remove a group from the space to make the resources unavailable

Value

• Access management via group is best practise in large organisations because single user management is error prone and manual work.

Acceptance Criteria

• When a group is removed from a space, the users have no more access to the space
• When a group is removed from a space, the space disappears from the list on all clients
• When a group member is removed in LDAP, the user looses access to the spaces via this group - > needs test

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

• Functional requirements
  [ ] functionality described in the user story works
  [ ] acceptance criteria are fulfilled
• Quality
  [ ] codre review happened
  [ ] Unit Tests
  [ ] Local Api tests
  [ ] CI is green
  [ ] critical code received unit tests by the developer
  [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
• Non-functional requirements
  [ ] no sonar cloud issues

[exalate-issue-sync]

Florian Schade commented: [~rhaferkamp]
i tested those via web ui, looks good to me....
When a group is removed from a space, the users have no more access to the space
When a group is removed from a space, the space disappears from the list on all clients

unfortunately i have no clue how to test:
When a group member is removed in LDAP, the user looses access to the spaces via this group - > needs test

can you help?

[exalate-issue-sync]

Ralf Haferkamp commented: [~fschade] This might be too obvious. I'll ask anyway ;-). Have you tried removing the user from the group via the Web UI? You can do that via the "group assignments" icon of the specific user in the users list.

Or are you looking for advice on how to create a test-case in ocis acceptance tests?

[exalate-issue-sync]

Michael Barz commented: [~vscharf] Can you check if we have a test for this?

IMO the implementation works as expected.

[exalate-issue-sync]

Florian Schade commented: all checked, expect test, good to go

[exalate-issue-sync]

Viktor Scharf commented: tests added:
api: #5365
e2e: owncloud/web#8185

[exalate-issue-sync]

Florian Schade commented: [~vscharf]😘 THX