fix dynamic inclusion of assets by setting SETTINGS_ASSET_PATH #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
kulmann
reviewed
Dec 8, 2020
| @@ -27,7 +26,7 @@ type assets struct { | |||
| func (a assets) Open(original string) (http.File, error) { | |||
| if a.config.Asset.Path != "" { | |||
| if stat, err := os.Stat(a.config.Asset.Path); err == nil && stat.IsDir() { | |||
| custom := filepath.Join( | |||
| custom := path.Join( | |||
There was a problem hiding this comment.
To be honest I don't get what difference this makes on a linux or mac computer. We are trying to use filepath everywhere because it is able to handle backslashes. Could you elaborate why/how this fixes asset loading? And for what it's worth, it might deserve a changelog then. ;-)
There was a problem hiding this comment.
my fault, i had some strange errors yesterday. it was on my machine only. closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
belongs to: #1031