Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: No entries in the sidebar after login #1031

Closed
exalate-issue-sync bot opened this issue Dec 7, 2020 · 6 comments · Fixed by owncloud/web#4430
Closed

Settings: No entries in the sidebar after login #1031

exalate-issue-sync bot opened this issue Dec 7, 2020 · 6 comments · Fixed by owncloud/web#4430
Labels

Comments

@exalate-issue-sync
Copy link

Steps to reproduce

  1. Log in with a user who has a role that allows them to access the settings
  2. Navigate to settings

Expected behavior

  • Entries in the left sidebar do always appear

Actual behavior

  • Entries in the left sidebar only appear after changing the language
@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: Also: on switching the language, left menu items get duplicated in the left sidebar, until the page is reloaded.

@exalate-issue-sync
Copy link
Author

exalate-issue-sync bot commented Dec 8, 2020

Benedikt Kulmann commented: There is more broken and I'd like to have it in this ticket:

  • Changing the language doesn't update only updates the left sidebar menu items on the first language switch (they should switch to a different language every time you change the language in settings)
  • When the settings ui is the active extension (i.e. I navigated into it), there are two menu items for the settings. One in the user menu and one in the app switcher.

@exalate-issue-sync exalate-issue-sync bot reopened this Dec 8, 2020
@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: We could pair on this if you fancy

@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: Apparently not updating the language after changing it in the settings multiple times only affects the left sidebar. Seems like everything else is handled properly.

@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: Since only the left sidebar is not updating after a language switch, the issue probably is that we use the route path of menu items as their keys in the sidebar component: https://github.com/owncloud/owncloud-design-system/blob/4bd20916a903fd802e6d1a2f20c844ca88c279a2/src/components/OcSidebar.vue#L31

@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: FYI I created two more issues from my comments here, so that this bug can be closed. The original issue is solved, so this is fine.
https://jira.owncloud.com/browse/OCIS-1172
https://jira.owncloud.com/browse/OCIS-1173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants