Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ocis config file option #1636

Merged
merged 2 commits into from
Feb 12, 2021
Merged

remove ocis config file option #1636

merged 2 commits into from
Feb 12, 2021

Conversation

wkloucek
Copy link
Contributor

Description

The oCIS root command offers a config file option ocis --config-file which does not do anything.

Related Issue

Motivation and Context

As far as I know, there aren't any plans to support a single config file which can be load by the oCIS root command.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Feb 12, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 7317c35 into master Feb 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove_ocis_config_file_option branch February 12, 2021 14:05
ownclouders pushed a commit that referenced this pull request Feb 12, 2021
@butonic
commit 7317c35
76c71ad 
Merge: 959225e 29eda7f
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Fri Feb 12 15:05:33 2021 +0100

    Merge pull request #1636 from owncloud/remove_ocis_config_file_option

    remove ocis config file option
@micbar micbar mentioned this pull request Feb 17, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot load config from file
2 participants
@wkloucek @butonic