Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay accounts service startup #1734

Merged
merged 2 commits into from Feb 26, 2021
Merged

Delay accounts service startup #1734

merged 2 commits into from Feb 26, 2021

Conversation

refs
Copy link
Member

@refs refs commented Feb 26, 2021

As it turns out the race condition between accounts <-> storage-metadata still remains. This PR is a hotfix and it should be followed up with a proper fix. Either:

  • block the accounts initialization until the storage metadata is ready (using the registry) or
  • allow the accounts service to initialize and use a message broker to signal the accounts the metadata storage is ready to receive requests.

@owncloud owncloud deleted a comment from update-docs bot Feb 26, 2021
phil-davis
phil-davis approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@individual-it individual-it mentioned this pull request Feb 26, 2021
Merged
@individual-it
Copy link
Member

CI keeps of failing with random problems, those hopefully would be fixed by #1669

@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit 3c0730c into master Feb 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the delay-accounts-execution branch February 26, 2021 16:52
ownclouders pushed a commit that referenced this pull request Feb 26, 2021
@individual-it
commit 3c0730c
27fb828 
Merge: a2e1e9f c71fbf2
Author: Artur Neumann <artur@jankaritech.com>
Date:   Fri Feb 26 22:37:27 2021 +0545

    Merge pull request #1734 from owncloud/delay-accounts-execution

    Delay accounts service startup
@micbar micbar mentioned this pull request Mar 9, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@refs @individual-it @phil-davis