Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay accounts service startup #1734

Merged
merged 2 commits into from Feb 26, 2021
Merged

Delay accounts service startup #1734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b2973
delay accounts service startup
refs Feb 26, 2021
c71fbf2
add changelog
refs Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/unreleased/accounts-init-regression.md
View file
Open in desktop
@@ -0,0 +1,8 @@
Bugfix: Purposely delay accounts service startup

As it turns out the race condition between `accounts <-> storage-metadata` still remains. This PR is a hotfix, and it should be followed up with a proper fix. Either:

- block the accounts' initialization until the storage metadata is ready (using the registry) or
- allow the accounts service to initialize and use a message broker to signal the accounts the metadata storage is ready to receive requests.

https://github.com/owncloud/ocis/pull/1734
4 changes: 1 addition & 3 deletions ocis/pkg/runtime/runtime.go
View file
Open in desktop
Expand Up @@ -50,13 +50,11 @@ var (
"thumbnails",
"web",
"webdav",
"accounts",
//"graph",
//"graph-explorer",
}

dependants = []string{
"storage-sharing",
"accounts",
}
// Maximum number of retries until getting a connection to the rpc runtime service.
maxRetries = 10
Expand Down