Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Adjust expected failures for remaining closed issues #2233

Merged
merged 1 commit into from
Jul 1, 2021
Merged

[Tests-Only] Adjust expected failures for remaining closed issues #2233

merged 1 commit into from
Jul 1, 2021

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Jun 30, 2021 •
edited
Loading

Description

This PR adjusts the tests in the exepected failures file which were linked with some closed issues.

Related Issue

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jasson99 jasson99 self-assigned this Jun 30, 2021
@jasson99
Copy link
Contributor Author

This PR adjusts all the tests linked to the closed issues in both owncloud and ocis storage, except the ones linked with: #1303 . @kiranparajuli589 shall be working on the ones linked with the particular issue

@jasson99 jasson99 force-pushed the adjustRemainingIssues branch 2 times, most recently from 238256e to 575b31d Compare July 1, 2021 10:54
@jasson99 jasson99 changed the title [Tests-Only]Adjust expected failures for remaining closed issues [Tests-Only] Adjust expected failures for remaining closed issues Jul 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jasson99 jasson99 merged commit 1103af6 into master Jul 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjustRemainingIssues branch July 1, 2021 14:05
ownclouders pushed a commit that referenced this pull request Jul 1, 2021
@jasson99
commit 1103af6
d110ef8 
Merge: 2300ab0 e2e6a2f
Author: Jasmine Baral <40829116+jasson99@users.noreply.github.com>
Date:   Thu Jul 1 19:50:03 2021 +0545

    Merge pull request #2233 from owncloud/adjustRemainingIssues

    [Tests-Only] Adjust expected failures for remaining closed issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@dpakach dpakach dpakach approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@jasson99 jasson99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

review issues listed in expected to fail file
3 participants
@jasson99 @phil-davis @dpakach