add basic API test for spaces #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
from
364e2ae
to
8230e16
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
from
8230e16
to
ff1a288
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
2 times, most recently
from
e37a2da
to
e272f5b
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
1 similar comment
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
from
e272f5b
to
e2e42c8
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
from
e2e42c8
to
6355bcc
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
from
6355bcc
to
51e3d21
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
from
51e3d21
to
8a013aa
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
from
8a013aa
to
5738db6
Compare
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
2 times, most recently
from
783d8e5
to
070443d
Compare
|
PR #2518 bumped the core commit id so that the API test code will now be running with the changes in core PR owncloud/core#39251 |
micbar
force-pushed
the
api-tests-spaces
branch
from
070443d
to
6e967c7
Compare
micbar
requested review from
individual-it,
phil-davis and
wkloucek
as code owners
micbar
force-pushed
the
api-tests-spaces
branch
from
6e967c7
to
490bea0
Compare
individual-it
requested changes
Sep 22, 2021
Co-authored-by: Artur Neumann <artur@jankaritech.com>
Co-authored-by: Artur Neumann <artur@jankaritech.com>
Co-authored-by: Artur Neumann <artur@jankaritech.com>
refs
reviewed
Oct 18, 2021
There was a problem hiding this comment.
👍 Works for me, LGTM.
Running as:
make test-acceptance-api \
TEST_SERVER_URL=https://localhost:9200 \
TEST_OCIS=true \
SKELETON_DIR=/Users/aunger/code/owncloud/core/apps/testing/data/apiSkeleton \
BEHAT_FEATURE=tests/acceptance/features/apiSpaces/ListSpaces.feature \
PATH_TO_CORE=/Users/aunger/code/owncloud/core/ \
OCIS_SKELETON_STRATEGY=upload \
OCIS_REVA_DATA_ROOT='' \
BEHAT_FILTER_TAGS='~@skipOnOcis-OCIS-Storage'
💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled... |
micbar
force-pushed
the
api-tests-spaces
branch
from
20e9788
to
72cb487
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
refs
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the ocis specific behat API test suite to be able to do basic Spaces API reguests
Related Issue
Motivation and Context
Get more API test coverage on new features
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: