Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Fix Guzzle7 exception handling in HttpRequestHelper #39251

Merged
merged 1 commit into from Sep 17, 2021

Conversation

phil-davis
Copy link
Contributor

Description

The getResponse() method was removed from GuzzleHttp\Exception\ConnectException in Guzzle7.

It still exists in GuzzleHttp\Exception\RequestException

So not all exceptions have a getResponse() method. Be more careful to only try to process a RequestException and check for a response. Do not catch other exceptions. They will throw higher up and eventually Behat will catch them and fail the test scenario and report the exception.

Related Issue

How Has This Been Tested?

CI - although the exception handling only happens in unusual circumstances.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Sep 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test-Framework] HttpREquestHelper not compatible with Guzzle 7
2 participants