Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GetSingleDrive handler #2978

Merged
merged 7 commits into from
Jan 19, 2022
Merged

add GetSingleDrive handler #2978

merged 7 commits into from
Jan 19, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jan 18, 2022 •
edited
Loading

Description

Add GET https://ocis.test/graph/v1.0/drives/{driveId}

Motivation and Context

Give the clients the possibility to lookup a single space by ID

How Has This Been Tested?

  • added acceptance test for personal space
  • added acceptance test for a project space

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 18, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar force-pushed the add-get-single-drive branch 2 times, most recently from d6394b1 to 3d6913d Compare January 18, 2022 15:45
@micbar micbar marked this pull request as ready for review January 18, 2022 15:46
@micbar micbar self-assigned this Jan 18, 2022
@micbar micbar added the Status:Needs-Review Needs review from a maintainer label Jan 18, 2022
ScharfViktor
ScharfViktor approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve

C0rby
C0rby suggested changes Jan 18, 2022
View reviewed changes
graph/pkg/service/v0/drives.go Outdated Show resolved Hide resolved
@micbar micbar requested a review from C0rby January 18, 2022 19:16
refs
refs suggested changes Jan 19, 2022
View reviewed changes
graph/pkg/service/v0/drives.go Outdated Show resolved Hide resolved
graph/pkg/service/v0/drives.go Outdated Show resolved Hide resolved
graph/pkg/service/v0/drives.go Outdated Show resolved Hide resolved
graph/pkg/service/v0/drives.go Show resolved Hide resolved
graph/pkg/service/v0/drives.go Outdated Show resolved Hide resolved
@micbar micbar requested a review from refs January 19, 2022 11:09
@micbar micbar force-pushed the add-get-single-drive branch 2 times, most recently from 5f3ff1f to 8bab057 Compare January 19, 2022 11:42
refs
refs suggested changes Jan 19, 2022
View reviewed changes
graph/pkg/service/v0/drives.go Outdated Show resolved Hide resolved
@micbar micbar requested a review from refs January 19, 2022 12:39
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

29.1% 29.1% Coverage
12.4% 12.4% Duplication

@micbar micbar merged commit 992fdf1 into master Jan 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-get-single-drive branch January 19, 2022 13:03
@micbar micbar mentioned this pull request Feb 16, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@refs refs refs approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@butonic butonic Awaiting requested review from butonic

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@fschade fschade Awaiting requested review from fschade

Assignees

@micbar micbar

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micbar @C0rby @refs @ScharfViktor