Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps for reva #328

Closed
wants to merge 5 commits into from
Closed

Update deps for reva #328

wants to merge 5 commits into from

Conversation

PVince81
Copy link
Contributor

Attempt to update deps for future reva, based on the deps commit in #323 and an addition to fix grpc version to fix compilation issue.

@PVince81 PVince81 self-assigned this Jun 22, 2020
@update-docs
Copy link

update-docs bot commented Jun 22, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@PVince81
Copy link
Contributor Author

For the record, here is the progress that led to this PR:

  1. Regular ocis master without replaces work for me locally.
  2. Checkout "ocis" master with the branch Update reva to 20200624 ocis-reva#279 and have both ocis-reva and reva (master) replaced in go.mod
  3. Run "go get" then compile with make clean build:
rm -rf config/identifier-registration.yaml
go clean -i ./...
rm -rf bin dist hugo
go build -v -tags '' -ldflags '-s -w -X "github.com/owncloud/ocis/pkg/version.String=284a999" -X "github.com/owncloud/ocis/pkg/version.Date=20200622"' -o bin/ocis ./cmd/ocis
github.com/cs3org/reva/pkg/eosclientgrpc/eos_grpc
# github.com/cs3org/reva/pkg/eosclientgrpc/eos_grpc
../../../../go/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200622084157-4925dc73ec86/pkg/eosclientgrpc/eos_grpc/eos_grpc.pb.go:4165:7: undefined: grpc.ClientConnInterface
../../../../go/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200622084157-4925dc73ec86/pkg/eosclientgrpc/eos_grpc/eos_grpc.pb.go:4169:11: undefined: grpc.SupportPackageIsVersion6
../../../../go/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200622084157-4925dc73ec86/pkg/eosclientgrpc/eos_grpc/eos_grpc.pb.go:4193:5: undefined: grpc.ClientConnInterface
../../../../go/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200622084157-4925dc73ec86/pkg/eosclientgrpc/eos_grpc/eos_grpc.pb.go:4196:22: undefined: grpc.ClientConnInterface
make: *** [Makefile:101: bin/ocis] Error 2
  1. This led to adding a replace for grpc as per advice from @C0rby, now getting this after go get and make clean build:
rm -rf config/identifier-registration.yaml
go clean -i ./...
rm -rf bin dist hugo
go build -v -tags '' -ldflags '-s -w -X "github.com/owncloud/ocis/pkg/version.String=f135c55" -X "github.com/owncloud/ocis/pkg/version.Date=20200622"' -o bin/ocis ./cmd/ocis
github.com/coreos/etcd/clientv3/balancer/resolver/endpoint
github.com/coreos/etcd/clientv3/balancer/picker
# github.com/coreos/etcd/clientv3/balancer/resolver/endpoint
../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.21+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:114:78: undefined: resolver.BuildOption
../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.21+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:182:31: undefined: resolver.ResolveNowOption
# github.com/coreos/etcd/clientv3/balancer/picker
../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.21+incompatible/clientv3/balancer/picker/err.go:37:44: undefined: balancer.PickOptions
../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.21+incompatible/clientv3/balancer/picker/roundrobin_balanced.go:55:54: undefined: balancer.PickOptions
make: *** [Makefile:101: bin/ocis] Error 2
  1. This sounds like the issue that @refs had fixed in his PR Public Link Data Service Command #323, so added here as well. The new output is:
rm -rf config/identifier-registration.yaml
go clean -i ./...
go: go.etcd.io/etcd@v0.5.0-alpha.5.0.20200425165423-262c93980547 used for two different module paths (github.com/coreos/etcd and go.etcd.io/etcd)
make: *** [Makefile:62: clean] Error 1

@PVince81
Copy link
Contributor Author

@PVince81
Copy link
Contributor Author

I've tried many combinations of replacement for etcd, even removing it from the top and keeping only in the replace section, but all are giving the errors at compilation time.

@PVince81
Copy link
Contributor Author

I just had another look at the original code that mentionned the workaround, which is in etcd-io/etcd#11563 (comment)

and as far as I can see the first statement is commented out, so I removed it.

I've pushed and now the error becomes:

rm -rf config/identifier-registration.yaml
go clean -i ./...
rm -rf bin dist hugo
go build -v -tags '' -ldflags '-s -w -X "github.com/owncloud/ocis/pkg/version.String=11995ff" -X "github.com/owncloud/ocis/pkg/version.Date=20200622"' -o bin/ocis ./cmd/ocis
github.com/coreos/etcd/clientv3/balancer/resolver/endpoint
github.com/coreos/etcd/clientv3/balancer/picker
# github.com/coreos/etcd/clientv3/balancer/resolver/endpoint
../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.22+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:114:78: undefined: resolver.BuildOption
../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.22+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:182:31: undefined: resolver.ResolveNowOption
# github.com/coreos/etcd/clientv3/balancer/picker
../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.22+incompatible/clientv3/balancer/picker/err.go:37:44: undefined: balancer.PickOptions
../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.22+incompatible/clientv3/balancer/picker/roundrobin_balanced.go:55:54: undefined: balancer.PickOptions
make: *** [Makefile:101: bin/ocis] Error 2

C0rby pushed a commit to owncloud/reva that referenced this pull request Jun 23, 2020
In ocis we currently face the problem that some of our dependencies rely on
grpc 1.26.0. With the upgraded grpc dependency in reva we were unable to
build ocis. And if we upgrade grpc in ocis the build failed because of
the other dependency.

I hoped we could downgrade grpc in reva until we have found a better
long term solution.

Here are some examples of our attempts to resolve this without this
downgrade. owncloud/ocis#328 (comment)

Signed-off-by: David Christofas <dchristofas@owncloud.com>
C0rby pushed a commit to owncloud/reva that referenced this pull request Jun 23, 2020
In ocis we currently face the problem that some of our dependencies rely on
grpc 1.26.0. With the upgraded grpc dependency in reva we were unable to
build ocis. And if we upgrade grpc in ocis the build failed because of
the other dependency.

I hoped we could downgrade grpc in reva until we have found a better
long term solution.

Here are some examples of our attempts to resolve this without this
downgrade. owncloud/ocis#328 (comment)
@PVince81
Copy link
Contributor Author

obsolete, grpc version was downgraded in reva

@PVince81 PVince81 closed this Jun 24, 2020
@PVince81 PVince81 deleted the update-deps-for-reva branch June 24, 2020 08:09
refs pushed a commit that referenced this pull request Sep 18, 2020
* Update reva to v0.1.1-0.20200701152626-2f6cc60e2f66

* update the api tests to core commit a3cac3dad60348fc962d1d8743b202bc5f79596b

Co-authored-by: Michael Barz <mbarz@owncloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants