add password reset link to login page #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idp/ui/src/containers/Login/Login.js
Outdated
| @@ -108,6 +110,8 @@ class Login extends React.PureComponent { | |||
| /> | |||
| {hasError && <Typography id="oc-login-error-message" variant="subtitle2" component="span" color="error" | |||
| className={classes.message}>{errorMessage}</Typography>} | |||
| <br /> | |||
| {loginFailed && passwordResetLink && <Link id="oc-login-password-reset" href={passwordResetLink} variant="subtitle2">{"Reset password?"}</Link>} | |||
There was a problem hiding this comment.
Can we wrap this into a <p> tag and have it with text-align: center;? :)
There was a problem hiding this comment.
I'm personally not a fan of that but yeah I can do it.
There was a problem hiding this comment.
Thanks, in my eyes it looks way better 😇 let me do a proper review now! Review incoming
C0rby
force-pushed
the
password-reset-link
branch
from
5fcb081
to
661baaa
Compare
|
Kudos, SonarCloud Quality Gate passed! |
pascalwengerter
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a configurable passwort reset link to the login page.
It can be set via
IDP_PASSWORD_RESET_URI. If the option is not set, the link will not be shown.It looks like this:
