Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Rename the search extensions environment variable for the grpc server address #3800

Merged
merged 2 commits into from
May 16, 2022
Merged

Bugfix: Rename the search extensions environment variable for the grpc server address #3800

merged 2 commits into from
May 16, 2022

Conversation

wkloucek
Copy link
Contributor

Description

We've fixed the gprc server address configuration environment variable by renaming it from
ACCOUNTS_GRPC_ADDR to SEARCH_GRPC_ADDR

WARNING: this could be considered as a breaking change!?

Related Issue

Motivation and Context

How Has This Been Tested?

  • none

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested a review from micbar May 16, 2022 06:36
@wkloucek
Copy link
Contributor Author

@micbar should we consider this as a breaking change and keep it backwards compatible?

@wkloucek wkloucek mentioned this pull request May 16, 2022
Closed
9 tasks
@mmattel
Copy link
Contributor

mmattel commented May 16, 2022

I guess that this will change the yaml/env file output - therefore docs relevant. Just hooking in so we can trigger a docs build.

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit d3025ec into owncloud:master May 16, 2022
ownclouders pushed a commit that referenced this pull request May 16, 2022
@wkloucek
commit d3025ec
f4167ea 
Merge: e52baab a933b61
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon May 16 11:37:35 2022 +0200

    Merge pull request #3800 from wkloucek/fix-search-grpc-addr-env

    Bugfix: Rename the search extensions environment variable for the grpc server address
@wkloucek wkloucek deleted the fix-search-grpc-addr-env branch May 20, 2022 07:39
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wkloucek @mmattel @micbar