Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy config revamp #3831

Merged
merged 2 commits into from
May 19, 2022
Merged

proxy config revamp #3831

merged 2 commits into from
May 19, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 19, 2022 •
edited
Loading

Description

Bugfix: remove legacy accounts proxy routes

We've removed the legacy accounts routes from the proxy default config.
There were no longer used since the switch to IDM as the default user
backend. Also accounts is no longer part of the oCIS binary and therefore
should not be part of the proxy default route config.

  • update routes on the deployments (fixes login error into oCIS in the parallel deployment)

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

ownclouders commented May 19, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiArchiver-ocis failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

dragonchaser
dragonchaser approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wkloucek wkloucek merged commit 5f4cd98 into owncloud:master May 19, 2022
@wkloucek wkloucek deleted the proxy-config-revamp branch May 19, 2022 08:32
ownclouders pushed a commit that referenced this pull request May 19, 2022
@wkloucek
commit 5f4cd98
b639b83 
Merge: b788552 a861f9c
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu May 19 10:32:10 2022 +0200

    Merge pull request #3831 from wkloucek/proxy-config-revamp

    proxy config revamp
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

@butonic butonic Awaiting requested review from butonic

@kobergj kobergj Awaiting requested review from kobergj

@rhafer rhafer Awaiting requested review from rhafer

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @ownclouders @dragonchaser