Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option to provide TLS certificate #3888

Merged
merged 1 commit into from
May 31, 2022
Merged

add config option to provide TLS certificate #3888

merged 1 commit into from
May 31, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented May 30, 2022

Added a config option to the graph service to provide a TLS certificate to be used to verify the LDAP server certificate.

Closes: #3818

@C0rby C0rby self-assigned this May 30, 2022
@C0rby C0rby added this to In progress in Infinite Scale Team Board via automation May 30, 2022
@ownclouders
Copy link
Contributor

ownclouders commented May 30, 2022

💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiAccountsHashDifficulty-ocis failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-7 failed. Further test are cancelled...

@C0rby
Copy link
Contributor Author

C0rby commented May 30, 2022

For some reason the CI is flaky... I rebased my branch now. Let's see if this helps.

@C0rby C0rby force-pushed the graph-cacert branch 2 times, most recently from d4165bc to 5ce11be Compare May 30, 2022 14:50
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

18.8% 18.8% Coverage
0.0% 0.0% Duplication

@C0rby C0rby requested a review from rhafer May 30, 2022 16:18
@C0rby C0rby merged commit b3569d6 into master May 31, 2022
Infinite Scale Team Board automation moved this from In progress to Done May 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the graph-cacert branch May 31, 2022 07:58
@wkloucek wkloucek mentioned this pull request May 31, 2022
9 tasks
wkloucek added a commit that referenced this pull request May 31, 2022
remove temporary GRAPH_LDAP_INSECURE workaround after fix in #3888
ownclouders pushed a commit that referenced this pull request May 31, 2022
Merge: 794db95 28c0375
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue May 31 11:59:33 2022 +0200

    Merge pull request #3896 from wkloucek/remove-temporary-workaround

    remove temporary GRAPH_LDAP_INSECURE workaround after fix in #3888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

GRAPH ldap backend is missing an option to configure the CA Cert for the LDAP connection
3 participants