-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add config option to provide TLS certificate #3888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled... |
💥 Acceptance test localApiTests-apiAccountsHashDifficulty-ocis failed. Further test are cancelled... |
💥 Acceptance test Core-API-Tests-ocis-storage-7 failed. Further test are cancelled... |
For some reason the CI is flaky... I rebased my branch now. Let's see if this helps. |
C0rby
requested review from
wkloucek,
phil-davis and
individual-it
as code owners
May 30, 2022 12:43
rhafer
requested changes
May 30, 2022
C0rby
force-pushed
the
graph-cacert
branch
2 times, most recently
from
May 30, 2022 14:50
d4165bc
to
5ce11be
Compare
Kudos, SonarCloud Quality Gate passed! |
rhafer
approved these changes
May 31, 2022
9 tasks
9 tasks
wkloucek
added a commit
that referenced
this pull request
May 31, 2022
remove temporary GRAPH_LDAP_INSECURE workaround after fix in #3888
ownclouders
pushed a commit
that referenced
this pull request
May 31, 2022
dragonchaser
pushed a commit
that referenced
this pull request
Jun 1, 2022
dragonchaser
pushed a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a config option to the graph service to provide a TLS certificate to be used to verify the LDAP server certificate.
Closes: #3818