Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multiple ldap insecure options #3897

Merged
merged 2 commits into from
May 31, 2022
Merged

fix multiple ldap insecure options #3897

merged 2 commits into from
May 31, 2022

Conversation

wkloucek
Copy link
Contributor

Description

We've fixed multiple LDAP insecure options:

  • The Graph LDAP insecure option default was set to true and now defaults to false. This is possible after add config option to provide TLS certificate #3888, since the Graph also now uses the LDAP CAcert by default.
  • The IDP OIDC insecure option was also used as IDP LDAP insecure option. These are now different settings.
  • The Graph LDAP insecure option was configurable by the environment variable OCIS_INSECURE, which was replaced by the dedicated LDAP_INSECURE variable. This variable is also used by all other services using LDAP.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested a review from rhafer May 31, 2022 08:42
@wkloucek wkloucek marked this pull request as draft May 31, 2022 08:45
@wkloucek wkloucek marked this pull request as ready for review May 31, 2022 10:00
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 8d00986 into owncloud:master May 31, 2022
@wkloucek wkloucek deleted the fix-ldap-insecure-options branch May 31, 2022 11:15
ownclouders pushed a commit that referenced this pull request May 31, 2022
@wkloucek
commit 8d00986
d8f9a63 
Merge: cf162e9 f7473df
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue May 31 13:14:58 2022 +0200

    Merge pull request #3897 from wkloucek/fix-ldap-insecure-options

    fix multiple ldap insecure options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@micbar micbar micbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wkloucek @rhafer @micbar