Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph/education: Check school number for duplicates before adding a school #7351

Merged
merged 7 commits into from Sep 27, 2023
Merged

graph/education: Check school number for duplicates before adding a school #7351

merged 7 commits into from Sep 27, 2023

Commits on Sep 27, 2023

  1. graph/education: Don't leak LDAP errors into the graph error message

    @rhafer
    rhafer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    50c84ef View commit details
    Browse the repository at this point in the history

  2. graph/education: Use helper for creating attribute list

    @rhafer
    rhafer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    8e126cb View commit details
    Browse the repository at this point in the history

  3. graph/education: Remove unreachable code 

    An LDAP Modify operation never returns LDAPResultEntryAlreadyExists errors.
That error can only happen for LDAPAdd or LDAPModifyDN.
    @rhafer
    rhafer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    93cb166 View commit details
    Browse the repository at this point in the history

  4. graph/education: Add getSchoolByNumber helper 

    Sometimes we explicit need to lookup by number and not numberOrID
    @rhafer
    rhafer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    ec9a58f View commit details
    Browse the repository at this point in the history

  5. graph/education: Check school number for duplicates before adding a s… 

    …chool
    @rhafer
    rhafer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    5a912c3 View commit details
    Browse the repository at this point in the history

  6. graph/education: slightly improve error handling and logging 

    - Use var for common errors
- Add the addition error message to the Error() output of errorcode.Error
- in PatchEducationSchool() use errorcode.RenderError() to turn the errorcode
  in to the right HTTP Status (instead of return 500 always)
    @rhafer
    rhafer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    ea73444 View commit details
    Browse the repository at this point in the history

  7. graph/education: Fix issues reported by sonarcloud

    @rhafer
    rhafer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    6d49450 View commit details
    Browse the repository at this point in the history