graph/education: Check school number for duplicates before adding a school #7351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
force-pushed
the
enterprise/6051
branch
3 times, most recently
from
e00db0f
to
b2c47ad
Compare
kobergj
requested changes
Sep 27, 2023
An LDAP Modify operation never returns LDAPResultEntryAlreadyExists errors. That error can only happen for LDAPAdd or LDAPModifyDN.
Sometimes we explicit need to lookup by number and not numberOrID
- Use var for common errors - Add the addition error message to the Error() output of errorcode.Error - in PatchEducationSchool() use errorcode.RenderError() to turn the errorcode in to the right HTTP Status (instead of return 500 always)
rhafer
force-pushed
the
enterprise/6051
branch
from
b2c47ad
to
ea73444
Compare
kobergj
approved these changes
Sep 27, 2023
rhafer
force-pushed
the
enterprise/6051
branch
from
f9ef193
to
6d49450
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Please backport after merging to stable-4.0 including the changelog |
This was referenced Sep 28, 2023
Closed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/owncloud/enterprise/issues/6051
Also contains a few minor cleanups. E.g. to make returned errors more consistent.