[Backport/4.0] graph/education: Check school number for duplicates before adding a school #7374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 164edd1)
(cherry picked from commit 16debe6)
An LDAP Modify operation never returns LDAPResultEntryAlreadyExists errors. That error can only happen for LDAPAdd or LDAPModifyDN. (cherry picked from commit ce808ea)
Sometimes we explicit need to lookup by number and not numberOrID (cherry picked from commit e2849bf)
…chool (cherry picked from commit 4f59de9)
- Use var for common errors - Add the addition error message to the Error() output of errorcode.Error - in PatchEducationSchool() use errorcode.RenderError() to turn the errorcode in to the right HTTP Status (instead of return 500 always) (cherry picked from commit a34d467)
(cherry picked from commit 4465c93)
kobergj
approved these changes
Sep 27, 2023
|
Kudos, SonarCloud Quality Gate passed! |
micbar
approved these changes
Sep 27, 2023
ownclouders
pushed a commit
that referenced
this pull request
Sep 27, 2023
[Backport/4.0] graph/education: Check school number for duplicates before adding a school
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks #7351 into stable/4.0