[tests-only][full-ci] removing the setResponse() in given/then step in GraphContext
#7399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nirajacharya2 please write more in the PR title. |
nirajacharya2
changed the title
setResponse() in given/then step in GraphContext
nirajacharya2
force-pushed
the
refactor-graph-context
branch
14 times, most recently
from
41ed89b
to
befe277
Compare
nirajacharya2
changed the title
setResponse() in given/then step in GraphContextsetResponse() in given/then step in GraphContext
nirajacharya2
force-pushed
the
refactor-graph-context
branch
9 times, most recently
from
7f53d2b
to
57c2f3c
Compare
nirajacharya2
requested review from
grgprarup,
KarunAtreya,
SwikritiT,
SagarGi,
saw-jan,
amrita-shrestha,
nabim777,
S-Panta and
PrajwolAmatya
nirajacharya2
force-pushed
the
refactor-graph-context
branch
3 times, most recently
from
7140bb5
to
6730f99
Compare
KarunAtreya
reviewed
Oct 17, 2023
Comment on lines
1454
to
1458
| if ($response === $response) { | ||
| $responseBody = $this->getJsonDecodedResponseBodyContent($response); | ||
| } else { | ||
| $responseBody = $this->getJsonDecodedResponseBodyContent(); | ||
| } |
There was a problem hiding this comment.
$response = $response ?? $this->response;
$responseBody = $this->getJsonDecodedResponseBodyContent($response);
| @@ -1445,13 +1445,17 @@ public function theOcsDataOfTheResponseShouldMatch( | |||
| * @Then the JSON data of the response should match | |||
| * | |||
| * @param PyStringNode $schemaString | |||
| * @param ResponseInterface $response | |||
There was a problem hiding this comment.
@param ResponseInterface|null $response
nirajacharya2
force-pushed
the
refactor-graph-context
branch
from
6730f99
to
5e909c7
Compare
Closed
6 tasks
nirajacharya2
force-pushed
the
refactor-graph-context
branch
4 times, most recently
from
7760048
to
7074ff6
Compare
nirajacharya2
force-pushed
the
refactor-graph-context
branch
from
7074ff6
to
4e12c48
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
Related Issue
part of: #7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: