Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] removing the setResponse() in given/then step in GraphContext #7646

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[tests-only][full-ci] removing the setResponse() in given/then step in GraphContext #7646

merged 1 commit into from
Nov 27, 2023

Conversation

nirajacharya2
Copy link
Contributor

Description

backport of : #7399

Related Issue

part of: #7082

Motivation and Context

  • To remove setResponse() and $this->response in the Given/Then steps and some helper functions
  • To avoid false positive assertions

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 mentioned this pull request Nov 7, 2023
Closed
6 tasks
@nirajacharya2 nirajacharya2 force-pushed the refactor-graph-context-bp branch 2 times, most recently from 836bb98 to c4f655d Compare November 7, 2023 04:15
@nirajacharya2 nirajacharya2 marked this pull request as ready for review November 7, 2023 04:46
@nirajacharya2 nirajacharya2 self-assigned this Nov 9, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SagarGi SagarGi merged commit b4b3827 into stable-4.0 Nov 27, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor-graph-context-bp branch November 27, 2023 08:39
ownclouders pushed a commit that referenced this pull request Nov 27, 2023
@nirajacharya2 @saw-jan
add query params to the log (#7493) (#7646)
a6960ce 
Co-authored-by: Sawjan Gurung <saw.jan.grg3e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@S-Panta S-Panta S-Panta approved these changes

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nirajacharya2 @saw-jan @S-Panta @PrajwolAmatya @SagarGi