feature(sharing): add graph endpoints to accept or decline a share #7885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Kudos, SonarCloud Quality Gate passed! |
fschade
force-pushed
the
graph-beta-share-accept-decline
branch
from
b5f3550
to
785d0e4
Compare
rhafer
force-pushed
the
graph-beta-share-accept-decline
branch
from
4890d4b
to
5900a6a
Compare
rhafer
force-pushed
the
graph-beta-share-accept-decline
branch
4 times, most recently
from
98f0e06
to
ed1ccb6
Compare
This was referenced Feb 14, 2024
|
Moving this to draft once more as this needs adjustments for matching the changed |
rhafer
force-pushed
the
graph-beta-share-accept-decline
branch
2 times, most recently
from
4f2f142
to
5d9c15a
Compare
rhafer
force-pushed
the
graph-beta-share-accept-decline
branch
from
5d9c15a
to
f389119
Compare
fschade
commented
Feb 28, 2024
fschade
commented
Feb 28, 2024
fschade
commented
Feb 28, 2024
kobergj
requested changes
Feb 28, 2024
…led implementation still missed
…terface After some back an forth we agreed on keeping the routes defined in a central place for now.
In theory creating the driveItem to accepting a shared resource
can be done via '/v1beta1/drives/{drive-id}/item/{item-id}/children'
but there is also the simplified variant via
'/v1beta1/drives/{drive-id}/root/children' (aligned with the example
in the spec). For now we'll just implement the latter because accepting
a share will always be done via root of the sharejail drive.
When accepting a share via 'POST /v1beta1/drives/{driveId}/root/children'
return the newly created driveItem. This driveItem wraps the accepted
remoteItem representing the shared resource (similar to the
'sharedWithMe' response.
This also refactors some of the helpers for user lookup and CS3 share to
driveItem conversion so they can be more easily shared.
Only accept requests against the shareJail driveID
errors.Join(errs...) ignores nil errors and returns nil if there are not errors.
rhafer
force-pushed
the
graph-beta-share-accept-decline
branch
from
f389119
to
954998a
Compare
|
kobergj
approved these changes
Feb 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With an objective to enhance our existing apis, this PR extends our Graph Service by introducing new endpoints for accepting and declining shares.
These features are not new additions in terms of functionality, as they were previously available in our legacy OCS API.
Open Tasks:
Related Issue
Motivation and Context
these Graph endpoints are designed to take over in the future, thereby paving a smooth transition
How Has This Been Tested?
Types of changes