Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(sharing): add graph endpoints to accept or decline a share #7885

Merged
merged 18 commits into from
Feb 28, 2024
Merged

feature(sharing): add graph endpoints to accept or decline a share #7885

merged 18 commits into from
Feb 28, 2024

Commits on Feb 28, 2024

  1. feature(sharing): add endpoints to accept or decline a share

    @fschade @rhafer
    fschade authored and rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    795d0fc View commit details
    Browse the repository at this point in the history

  2. enhancement: add basic share accept feature, error handling and detai… 

    …led implementation still missed
    @fschade @rhafer
    fschade authored and rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a5b70b3 View commit details
    Browse the repository at this point in the history

  3. enhancement: make use of body driveItem for graph share accept

    @fschade @rhafer
    fschade authored and rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    796233c View commit details
    Browse the repository at this point in the history

  4. enhancement: handle share mount errors

    @fschade @rhafer
    fschade authored and rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    92fc17d View commit details
    Browse the repository at this point in the history

  5. enhancement: add basic share unmount

    @fschade @rhafer
    fschade authored and rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    877f233 View commit details
    Browse the repository at this point in the history

  6. enhancement: add DrivesDriveItemApi DeleteDriveItem tests

    @fschade @rhafer
    fschade authored and rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c10d7dd View commit details
    Browse the repository at this point in the history

  7. test: improve graph share accept/decline test coverage

    @fschade @rhafer
    fschade authored and rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5c39725 View commit details
    Browse the repository at this point in the history

  8. test: add more tests for the DrivesDriveItemService implementation

    @fschade @rhafer
    fschade authored and rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d48da96 View commit details
    Browse the repository at this point in the history

  9. fix(graph): Remove duplicated routes from router

    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    54226ae View commit details
    Browse the repository at this point in the history

  10. enhancement(graph): refrain from registering routes via the Router in… 

    …terface

After some back an forth we agreed on keeping the routes defined
in a central place for now.
    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e7985f4 View commit details
    Browse the repository at this point in the history

  11. enhancement(sharing): Simplify route for accepting shares 

    In theory creating the driveItem to accepting a shared resource
can be done via '/v1beta1/drives/{drive-id}/item/{item-id}/children'
but there is also the simplified variant via
'/v1beta1/drives/{drive-id}/root/children' (aligned with the example
in the spec). For now we'll just implement the latter because accepting
a share will always be done via root of the sharejail drive.
    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c8a89e9 View commit details
    Browse the repository at this point in the history

  12. enhancement(sharing): Return newly created driveItem 

    When accepting a share via 'POST /v1beta1/drives/{driveId}/root/children'
return the newly created driveItem. This driveItem wraps the accepted
remoteItem representing the shared resource (similar to the
'sharedWithMe' response.

This also refactors some of the helpers for user lookup and CS3 share to
driveItem conversion so they can be more easily shared.
    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7edc2fe View commit details
    Browse the repository at this point in the history

  13. enhancement(sharing): allow unmounting a share

    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    35acae1 View commit details
    Browse the repository at this point in the history

  14. docs: Add changelog for share (un)mount

    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d38bd46 View commit details
    Browse the repository at this point in the history

  15. Fix typos

    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    10babaf View commit details
    Browse the repository at this point in the history

  16. enhancement(sharing): Check driveID when unmounting share 

    Only accept requests against the shareJail driveID
    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    64f6c14 View commit details
    Browse the repository at this point in the history

  17. fix: Remove unneeded code 

    errors.Join(errs...) ignores nil errors and returns nil if there are not errors.
    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f5a282c View commit details
    Browse the repository at this point in the history

  18. docs: Add missing doc comments

    @rhafer
    rhafer committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    954998a View commit details
    Browse the repository at this point in the history