Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] remove outdated and unused cldr dep from kpop in idp package #7988

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[full-ci] remove outdated and unused cldr dep from kpop in idp package #7988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/fix-remove-unused-idp-dependency.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Removed outdated and unused dependency from idp package

We've removed the outdated and apparently unused dependency `cldr` from the `kpop` dependency inside the idp web ui. This resolves a security issue around an oudated `xmldom` package version, originating from said `kpop` library.

https://github.com/owncloud/ocis/issues/7957
https://github.com/owncloud/ocis/pull/7988
5 changes: 5 additions & 0 deletions services/idp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,5 +153,10 @@
"webpack": "4.47.0",
"webpack-manifest-plugin": "4.1.1",
"workbox-webpack-plugin": "7.0.0"
},
"pnpm": {
"overrides": {
"kpop>cldr": ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a comment or link this pr for now ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Douglas Crockford:

I removed comments from JSON because I saw people were using them to hold parsing directives, a practice which would have destroyed interoperability. I know that the lack of comments makes some people sad, but it shouldn't.

Suppose you are using JSON to keep configuration files, which you would like to annotate. Go ahead and insert all the comments you like. Then pipe it through JSMin before handing it to your JSON parser.

TL;DR: no comments in json. Vscode and TS allow it, but it's non-standard and pnpm doesn't.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's in fact why I didn't add a comment :-)

}
}
}
33 changes: 4 additions & 29 deletions services/idp/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.