Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Bump Reva #8038

Merged
merged 1 commit into from Dec 21, 2023
Merged

[full-ci] Bump Reva #8038

merged 1 commit into from Dec 21, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Dec 20, 2023

Bumps reva

Fixes #7697

@saw-jan
Copy link
Member

saw-jan commented Dec 21, 2023

Scenario is refusing to pass:

  Scenario: personal space is deleted automatically when the user is deleted                          # /drone/src/tests/acceptance/features/apiGraph/deleteUser.feature:147
    Given the administrator has assigned the role "Admin" to user "Alice" using the Graph API         # GraphContext::theAdministratorHasGivenTheRoleUsingTheGraphApi()
    And user "Brian" has been created with default attributes and without skeleton files              # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
    When the user "Alice" deletes a user "Brian" using the Graph API                                  # GraphContext::theUserDeletesAUserUsingTheGraphAPI()
    Then the HTTP status code should be "204"                                                         # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    When user "Alice" lists all spaces via the Graph API with query "$filter=driveType eq 'personal'" # SpacesContext::theUserListsAllAvailableSpacesUsingTheGraphApi()
    Then the json responded should not contain a space with name "Brian Murphy"                       # SpacesContext::jsonRespondedShouldNotContain()
      space Brian Murphy should not be available for a user
      Failed asserting that an array is empty.

Tried it locally - test was passing

@kobergj
Copy link
Collaborator Author

kobergj commented Dec 21, 2023

Same here. Test is failing in ci every time. Locally works fine. I'm running some older reva version to narrow down the error.

@kobergj kobergj marked this pull request as draft December 21, 2023 13:49
@rhafer
Copy link
Contributor

rhafer commented Dec 21, 2023

Same here. Test is failing in ci every time. Locally works fine. I'm running some older reva version to narrow down the error.

Argh. With the change in the user provider disabled it's succeeding. Still trying do understand why it's not happening locally ...

@rhafer
Copy link
Contributor

rhafer commented Dec 21, 2023

I think I am able to reproduce the problem now. It seems to only happens if you run the whole apiGraph/deleteUser.feature file. Just running the apiGraph/deleteUser.feature:147 test is not enough ...

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rhafer
Copy link
Contributor

rhafer commented Dec 21, 2023

@kobergj The failure is caused by cs3org/reva#4426 I just don't understand why yet 😭

@kobergj kobergj marked this pull request as ready for review December 21, 2023 16:30
@kobergj kobergj merged commit 4a23394 into owncloud:master Dec 21, 2023
4 checks passed
ownclouders pushed a commit that referenced this pull request Dec 21, 2023
@micbar micbar mentioned this pull request Dec 27, 2023
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ocis crashed: fatal error: concurrent map read and map write
3 participants