usersprovider: Allow admins to read disabled users by ID #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deny permission when there is not user in the Context, instead of panicking. This is needed for unprotected API Call that might need to check permissions (like e.g. GetUser).
Users with the account management permission need to be able to lookup disabled users. (E.g. when listing the spaces of a user). This adds the "Accounts.ReadWrite" permission that is checked when looking up users.
rhafer
force-pushed
the
get-disabled-user-by-id
branch
from
f22b8fd
to
2090ff5
Compare
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 21, 2023
This is needed for the permission checks introduced in cs3org/reva#4430
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 21, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 21, 2023
This is needed for the permission checks introduced in cs3org/reva#4430
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 21, 2023
|
I'll close this for now. Until we have sorted out the details of owncloud/ocis#8161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users with the account management permission need to be able to lookup disabled users. (E.g. when listing the spaces of a user). This adds the "Accounts.ReadWrite" permission that is checked when looking up users.
This is supposed to fix the DeleteUser failure seen in: owncloud/ocis#8038 which was introduced with: #4426
As an alternative quickfix (if this one needs more thoughs) I've also posted revert PR here: #4431