Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Restart Postprocessing Logic #8782

Merged
merged 3 commits into from Apr 9, 2024

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Apr 4, 2024

  • It was only working with an inmemory store
  • Added a restart parameter to the ocis storage-users uploads sessions command. It will restart all listed sessions

@kobergj kobergj marked this pull request as ready for review April 8, 2024 07:59
Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to change the output of existing cli and we should add a --ignore-errors flag to allow continuing after errors. It is very annoying to be stuck in a situation where you cannot retrigger a lot of upload sessions just because one of them is somehow rotten.

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
Copy link
Collaborator Author

kobergj commented Apr 8, 2024

@butonic did changes as discussed. Also needed to rebase because it was out of sync with master. Sorry.

Please recheck.

@kobergj kobergj requested a review from butonic April 8, 2024 09:26
@mmattel
Copy link
Contributor

mmattel commented Apr 8, 2024

Hooking myself in because of possible admin docs changes.

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Copy link

sonarcloud bot commented Apr 8, 2024

@kobergj kobergj merged commit 5f96680 into owncloud:master Apr 9, 2024
4 checks passed
@kobergj kobergj deleted the FixPostprocessingRestart branch April 9, 2024 06:18
ownclouders pushed a commit that referenced this pull request Apr 9, 2024
@ScharfViktor ScharfViktor mentioned this pull request Apr 9, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants