-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] adding test for listing permission of personal drive #8901
base: master
Are you sure you want to change the base?
Conversation
30be0cb
to
c611a30
Compare
c611a30
to
1643662
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Scenario: user lists the permissions of their personal spaces | ||
When user "Alice" lists the permissions of space "Personal" using the Graph API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response is different from using drives.root
endpoint. Needs clarifications here.
Should listing permissions of Personal
space's root path be possible?
this step uses drives.permissions.
: drives/<drive-id>/items/<root-path-id>/permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using drives.root
endpoint, it is not possible to list Personal space permissions
ocis/tests/acceptance/features/apiSharingNg/listPermissions.feature
Lines 1040 to 1045 in 0960d7f
Scenario Outline: try to lists the permissions of a Personal/Shares drive using root endpoint | |
Given using spaces DAV path | |
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API | |
And user "Alice" has created a space "new-space" with the default quota using the Graph API | |
When user "Alice" tries to list the permissions of space "<drive>" using root endpoint of the Graph API | |
Then the HTTP status code should be "400" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made an issue regarding this #8922
|
||
|
||
Scenario: user lists the permissions of their personal spaces | ||
When user "Alice" lists the permissions of space "Personal" using the Graph API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirajacharya2 Could you rename this as:
When user "Alice" lists the permissions of space "Personal" using the Graph API | |
When user "Alice" lists the permissions of space "Personal" using permissions endpoint of the Graph API |
@@ -1079,3 +1079,122 @@ Feature: List a sharing permissions | |||
| drive | | |||
| Personal | | |||
| Shares | | |||
|
|||
|
|||
Scenario: user lists the permissions of their personal spaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scenario: user lists the permissions of their personal spaces | |
Scenario: user lists the permissions of Personal spaces (permissions endpoint) |
currently blocked by #8922 |
Description
this pr adds test for listing permissions of personal drive
added scenarios
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: