[tests-only] separate different SharingNG share steps #9097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
force-pushed
the
tests/refactor-sharing-steps
branch
from
28b1703
to
d900e31
Compare
saw-jan
requested review from
grgprarup,
Salipa-Gurung,
amrita-shrestha,
S-Panta and
ScharfViktor
test: separate resource sharing GIven step from space share test: share space via root endpoint in Given steps test: use existing step test: fix more steps
test: fix php code style
saw-jan
force-pushed
the
tests/refactor-sharing-steps
branch
from
b34dccf
to
657fad5
Compare
|
SagarGi
reviewed
May 8, 2024
| @@ -56,6 +56,8 @@ public function before(BeforeScenarioScope $scope): void { | |||
| } | |||
|
|
|||
| /** | |||
| * Create link share of itme (resource) or drive (space) using drives.permissions endpoint | |||
There was a problem hiding this comment.
Suggested change
| * Create link share of itme (resource) or drive (space) using drives.permissions endpoint | |
| * Create link share of item (resource) or drive (space) using drives.permissions endpoint |
| * @Given /^user "([^"]*)" has created the following space link share:$/ | ||
| * | ||
| * @param string $user | ||
| * @param TableNode|null $body |
There was a problem hiding this comment.
Suggested change
| * @param TableNode|null $body | |
| * @param TableNode $body |
| * Create link share of drive (space) using drives.root endpoint | ||
| * | ||
| * @param string $user | ||
| * @param TableNode|null $body |
There was a problem hiding this comment.
Suggested change
| * @param TableNode|null $body | |
| * @param TableNode $body |
This was referenced May 8, 2024
ownclouders
pushed a commit
that referenced
this pull request
May 8, 2024
* separate When steps using root and permissions endpoints test: separate resource sharing GIven step from space share test: share space via root endpoint in Given steps test: use existing step test: fix more steps * test: separate resource and space link share creation test: fix php code style
9 tasks
DeepDiver1975
pushed a commit
that referenced
this pull request
May 8, 2024
* separate When steps using root and permissions endpoints test: separate resource sharing GIven step from space share test: share space via root endpoint in Given steps test: use existing step test: fix more steps * test: separate resource and space link share creation test: fix php code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes
Checklist: