This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Remove icon prop, UIKit styles and add css grid into buttons #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
force-pushed
the
feature/icon-on-right-in-button
branch
from
09f8b7e
to
d3aa49e
Compare
DeepDiver1975
previously requested changes
Jul 13, 2019
|
do we have a concrete example where we need this in Phoenix ? should we move forward ? |
Needed e. g. in roles dropdown in collaborators to add chevron on the right side of the button to really tell users that it is select and not just a button.
|
|
Ah, I didn't realize that the role field was a button |
|
@PVince81 @DeepDiver1975 Is here agreement on a solution? I'd go ahead and implement either of them, just let me know which one 😉 |
LukasHirt
force-pushed
the
feature/icon-on-right-in-button
branch
from
d3aa49e
to
9d715ec
Compare
|
Code updated. @DeepDiver1975 pls re-review |
LukasHirt
force-pushed
the
feature/icon-on-right-in-button
branch
from
9d715ec
to
88c57c6
Compare
LukasHirt
changed the title
LukasHirt
dismissed
DeepDiver1975’s stale review
The scope of this PR changed quite and have different changes.
LukasHirt
force-pushed
the
feature/icon-on-right-in-button
branch
from
88c57c6
to
65320e2
Compare
5 tasks
LukasHirt
commented
Aug 5, 2020
src/styles/theme/oc-button.scss
Outdated
| &.uk-button-secondary, | ||
| &.uk-button-danger { | ||
| &-primary, | ||
| &-secondary, |
|
Didn't notice this PR until now, sorry. Can you rebase? @LukasHirt |
… now Use css grid, remove UIKit styles from button and move docs into docs block
LukasHirt
force-pushed
the
feature/icon-on-right-in-button
branch
from
65320e2
to
932f4e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having complete freedom when adding icons and using the css grid to preserve our defined gutters.
Related issue
Screenshot