Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about number of selected items and their size #3850

Merged
merged 1 commit into from Aug 21, 2020

Conversation

LukasHirt
Copy link
Contributor

Description

We've added information about the number of selected items and their size above the files list next to batch actions.

Related Issue

How Has This Been Tested?

  • Select multiple resources in different files lists.

Screenshots (if appropriate):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jul 28, 2020
@LukasHirt LukasHirt requested a review from kulmann July 28, 2020 21:35
@LukasHirt LukasHirt self-assigned this Jul 28, 2020
@LukasHirt LukasHirt added this to In progress in oCIS Sprint 20-15 via automation Jul 28, 2020
@LukasHirt
Copy link
Contributor Author

The interaction to clear selection doesn't look different at all currently. Is taken care of in owncloud/owncloud-design-system#418

@LukasHirt
Copy link
Contributor Author

LukasHirt commented Jul 31, 2020

  • remove selected text from buttons

@LukasHirt LukasHirt moved this from In progress to To review in oCIS Sprint 20-15 Aug 3, 2020
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some visual things I noticed:

  • Clear selection raw button has a height of 22px, while the text left of it has a height of 17px. Because of this, the Clear selection text overflows to the bottom, which looks off.
  • The pipe | between text and clear selection button is quite short. I would expect it to have the same height as all the other text.
  • When you shrink the windows size so that the left sidebar disappears, the info about selected items and the clear selection button disappear entirely. Might be intended, but this way shrinking the windows causes the ui to lose information and one quite handy action (clearing the selection).
  • selected suffix from the action buttons still needs to be removed ;-)

@LukasHirt
Copy link
Contributor Author

LukasHirt commented Aug 5, 2020

When you shrink the windows size so that the left sidebar disappears, the info about selected items and the clear selection button disappear entirely. Might be intended, but this way shrinking the windows causes the ui to lose information and one quite handy action (clearing the selection).

This is on purpose until we figure out the app bar layout on smaller screens. Adding there more elements makes it almost unusable already. #3774

selected suffix from the action buttons still needs to be removed ;-)

It was already removed in the previous commit. Just forgot to remove it now from tests - will do next

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LukasHirt
Copy link
Contributor Author

Clear selection raw button has a height of 22px, while the text left of it has a height of 17px. Because of this, the Clear selection text overflows to the bottom, which looks off.

I've aligned it with flexbox.

The pipe | between text and clear selection button is quite short. I would expect it to have the same height as all the other text.

With the flexbox in place, it should be now aligned as well. But since it's using font size it's possible that some screens might slightly differ.

Here's a screenshot with the new alignment:

image

image

@LukasHirt LukasHirt force-pushed the feature/multi-select-info branch 2 times, most recently from a51554b to 06828e2 Compare August 17, 2020 08:41
@LukasHirt LukasHirt force-pushed the feature/multi-select-info branch 3 times, most recently from a3d4b61 to 43c9787 Compare August 20, 2020 21:08
We've added information about the number of selected items and their size above the files list next to batch actions
@LukasHirt LukasHirt merged commit 02ee59f into master Aug 21, 2020
@LukasHirt LukasHirt deleted the feature/multi-select-info branch August 21, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
No open projects
oCIS Sprint 20-15
  
To review
Development

Successfully merging this pull request may close these issues.

Unify multi-select info and add size
2 participants