test-acceptance-api and test-acceptance-webui makefile targets #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
requested review from
PVince81,
DeepDiver1975,
individual-it,
patrickjahns and
davitol
individual-it
approved these changes
Sep 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
Coverage 72.83% 72.83%
Complexity 225 225
=========================================
Files 25 25
Lines 968 968
=========================================
Hits 705 705
Misses 263 263Continue to review full report at Codecov.
|
|
@patrickjahns @PVince81 @DeepDiver1975 any opinions here? |
phil-davis
force-pushed
the
makefile-test-acceptance
branch
from
4af82b0
to
cd3e683
Compare
|
Also see core PR owncloud/core#32769 for an intial proposed implementation in core. |
phil-davis
force-pushed
the
makefile-test-acceptance
branch
2 times, most recently
from
3ade029
to
285ddfe
Compare
|
Rebase to check that it still works fine. The equivalent has been merged in core yesterday, so I will merge here when CI passes. |
phil-davis
force-pushed
the
makefile-test-acceptance
branch
from
285ddfe
to
20dba8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working towards having proper Makefile build targets for each of the parts of testing -
make test-php-stylemake test-php-style-fixetc.Acceptance tests currently come in 2 different flavors. API tests only need a server running somewhere and some client utility code (Guzzle, curl...) on the test script side. webUI tests also need a browser environment and whatever middleware to talk to the browser (e.g. Mink to selenium). We currently do not mix running API and webUI acceptance tests in a single run.
So I am proposing that we have 2 build targets:
For discussion, please comment. e.g.