Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore package-lock.json files #141

Closed
felixheidecke opened this issue May 30, 2018 · 7 comments
Closed

Ignore package-lock.json files #141

felixheidecke opened this issue May 30, 2018 · 7 comments
Assignees
Labels
Category:Enhancement Add new functionality

Comments

@felixheidecke
Copy link
Contributor

I suggest ignoring the package-lock.json files altogether. They do not make sense as we pre-compile and pack Applications anyway instead of having the user compile it for themselves.

@PVince81
Copy link
Contributor

@felixheidecke we need them for the build script that will build these pre-compiled packages so we have consistent lib versions and deterministic builds.

@PVince81 PVince81 removed their assignment Jun 5, 2018
@felixheidecke
Copy link
Contributor Author

I need to look into suppress the creation of a package-lock.json file in a node development environment since it makes no sense here. For production, sure … locking packages make sense.

@scramb
Copy link
Contributor

scramb commented Oct 23, 2018

As recommend in npm/npm#18007
They suggest using npm-merge-driver package which tells git how to fast-forward merge the conflicts in package-lock. The other way to go is using yarn instead of npm. Since the yarn-lock file is not json, this feels easier to handle imo.

@DeepDiver1975
Copy link
Member

we anyhow wanted to switch to yarn ....

@scramb
Copy link
Contributor

scramb commented Oct 30, 2018

@DeepDiver1975 should i add yarn to #286 or shall i prepare a new one with the whole process and yarn in another PR?

@DeepDiver1975
Copy link
Member

I'm fine putting this into #286 - THX

@tempelgogo
Copy link
Contributor

merged implicit with yarn migration #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

No branches or pull requests

5 participants