Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Drag and drop does not work with IE11 #2119

Closed
jnweiger opened this issue Oct 1, 2019 · 9 comments
Closed

[QA] Drag and drop does not work with IE11 #2119

jnweiger opened this issue Oct 1, 2019 · 9 comments
Assignees
Labels
Priority:p3-medium Normal priority

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Oct 1, 2019

Drag and drop a folder does not work. This is fine. Folder upload is disabled for IE11.
Drag and drop a file also does not work

image

We get the same error message when dropping a jpeg file as for a folder.
Expect this upload to succeed.

@jnweiger jnweiger added the Priority:p1-urgent Consider a hotfix release with only that fix label Oct 1, 2019
@jnweiger
Copy link
Contributor Author

jnweiger commented Oct 1, 2019

Seen on Windows 10 with

image

image

@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Oct 1, 2019
@jnweiger
Copy link
Contributor Author

jnweiger commented Oct 4, 2019

ACL Version: 0.2.4-63760d1 (1570179040161)
With IE11:

  • no more error messages.
  • Instead, the file is opened in the browser (or added as a download), which is normal windows behaviour, when a website does not react to drag and drop.

With Firefox:

  • Drag and Drop still uploads (as expected)

@hodyroff is this acceptable behaviour?
I suggest to open a new low prio issue to implement a nicer message.

As a user I am surprised that IE11 opens its download manager, when I try to trigger an upload by drag and drop. Somewhat counterintuitive.

@jnweiger
Copy link
Contributor Author

jnweiger commented Oct 10, 2019

Tested on ACL Version: 0.2.4-4e667ef (1570697905792)
As above. Its a WONTFIX for IE11
Drag+Drop works fine with Edge, FireFox, Crhome. Even folders with subdirs work.

@hodyroff Requires Documentation!

@PVince81
Copy link
Contributor

@LukasHirt what was the chosen approach in the end ? anything left to do for Phoenix ?

@LukasHirt
Copy link
Contributor

@PVince81 At the moment it is completely disabled for ie 11. As soon as the time permits we should look into it deeper and solve the issues there so it's available also in ie11. (needs to be decided what priority it is)

@hodyroff
Copy link

IMO Won't fix for IE11 ... The current solution works for me also from a product standpoint.
Document and be done.

@PVince81
Copy link
Contributor

@pmaier1 ^

@PVince81 PVince81 assigned pmaier1 and unassigned LukasHirt Oct 14, 2019
@PVince81 PVince81 added Priority:p3-medium Normal priority and removed Priority:p1-urgent Consider a hotfix release with only that fix labels Oct 14, 2019
@PVince81
Copy link
Contributor

@pmaier1 do you agree with the decision ?

@PVince81
Copy link
Contributor

dropped support for IE11, won't fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority
Projects
None yet
Development

No branches or pull requests

5 participants