Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize CI #60

Merged
merged 4 commits into from
Dec 13, 2018
Merged

Standardize CI #60

merged 4 commits into from
Dec 13, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Dec 12, 2018

Issue #54

  • standardize Makefile .drone.yml etc
  • add coding standard. phan and phpstan to Makefile and drone scripts
  • apply coding standard changes and add coding standard tests to drone matrix
  • split API acceptance tests in to 2 suites (because a single suite was taking about 35 minutes to finish, a bit too long)

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #60 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #60      +/-   ##
===========================================
+ Coverage         2%   2.01%   +<.01%     
  Complexity      214     214              
===========================================
  Files            22      22              
  Lines           998     995       -3     
===========================================
  Hits             20      20              
+ Misses          978     975       -3
Impacted Files Coverage Δ Complexity Δ
lib/adminpanel.php 0% <ø> (ø) 3 <0> (ø) ⬇️
command/reset.php 0% <ø> (ø) 2 <0> (ø) ⬇️
add.php 0% <0%> (ø) 0 <0> (ø) ⬇️
jobs/updatemetadata.php 0% <0%> (ø) 9 <9> (ø) ⬇️
command/index.php 0% <0%> (ø) 10 <0> (ø) ⬇️
db/statusmapper.php 0% <0%> (ø) 35 <12> (ø) ⬇️
search/elasticsearchprovider.php 0% <0%> (ø) 16 <5> (ø) ⬇️
controller/adminsettingscontroller.php 34.48% <0%> (ø) 10 <0> (ø) ⬇️
appinfo/app.php 0% <0%> (ø) 0 <0> (ø) ⬇️
appinfo/routes.php 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193cd3e...0ad95c4. Read the comment docs.

@phil-davis
Copy link
Contributor Author

I scored 0% codecov of the patch diff - it thinks none of lines auto-changed by php-cs-fixer are covered by unit tests. Project code coverage of this app is only 2% - seems a bit low.

@phil-davis phil-davis merged commit 33b100d into master Dec 13, 2018
@delete-merged-branch delete-merged-branch bot deleted the standardize-CI branch December 13, 2018 09:50
@phil-davis phil-davis mentioned this pull request Dec 13, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants