fix: resolving private links to hidden shares

changelog/unreleased/enhancement-show-hide-shares

@@ -8,3 +8,4 @@ Furthermore, accepting and rejecting shares has been renamed to "enable sync"/"d
 https://github.com/owncloud/web/issues/9531
 https://github.com/owncloud/web/pull/9718
 https://github.com/owncloud/web/pull/10097
+https://github.com/owncloud/web/pull/10321

packages/web-runtime/src/pages/resolvePrivateLink.vue

@@ -52,7 +52,8 @@ import {
   useRouteQuery,
   useConfigurationManager,
   createLocationSpaces,
-  createLocationShares
+  createLocationShares,
+  useClientService
 } from '@ownclouders/web-pkg'
 import { unref, defineComponent, computed, onMounted, ref, Ref } from 'vue'
 // import { createLocationSpaces } from 'web-app-files/src/router'
@@ -70,6 +71,8 @@ export default defineComponent({
     const id = useRouteParam('fileId')
     const configurationManager = useConfigurationManager()
     const { $gettext } = useGettext()
+    const clientService = useClientService()
+
     const resource: Ref<Resource> = ref()
     const sharedParentResource: Ref<Resource> = ref()
     const isUnacceptedShareError = ref(false)
@@ -114,9 +117,14 @@ export default defineComponent({
       }
 
       let resourceIsNestedInShare = false
+      let isHiddenShare = false
       if (isShareSpaceResource(space)) {
         sharedParentResource.value = resource
         resourceIsNestedInShare = path !== '/'
+        if (!resourceIsNestedInShare && space.shareId) {
+          const { shareInfo } = yield clientService.owncloudSdk.shares.getShare(space.shareId)
+          isHiddenShare = shareInfo.hidden === 'true'
+        }
       }
 
       let fileId: string
@@ -145,6 +153,7 @@ export default defineComponent({
         scrollTo:
           targetLocation.name === 'files-shares-with-me' ? space.shareId : unref(resource).fileId,
         ...(unref(details) && { details: unref(details) }),
+        ...(isHiddenShare && { 'q_share-visibility': 'hidden' }),
         ...(openWithDefault && { openWithDefaultApp: 'true' })
       }
 

packages/web-runtime/tests/unit/pages/resolvePrivateLink.spec.ts

@@ -74,6 +74,28 @@ describe('resolvePrivateLink', () => {
         expect.objectContaining({ name: 'files-shares-with-me' })
       )
     })
+    it('adds the hidden share param for hidden shares', async () => {
+      const fileId = '1'
+      const driveAliasAndItem = 'shares/someShare'
+      const space = mock<SpaceResource>({
+        driveType: 'share',
+        getDriveAliasAndItem: () => driveAliasAndItem
+      })
+      const resource = mock<Resource>({ fileId, type: 'file' })
+      const { wrapper, mocks } = getWrapper({
+        space,
+        resource,
+        fileId,
+        path: '/',
+        hiddenShare: true
+      })
+      await wrapper.vm.resolvePrivateLinkTask.last
+      expect(mocks.$router.push).toHaveBeenCalledWith(
+        expect.objectContaining({
+          query: expect.objectContaining({ 'q_share-visibility': 'hidden' })
+        })
+      )
+    })
   })
   it('passes the details query param if given via query', async () => {
     const details = 'sharing'
@@ -137,6 +159,7 @@ function getWrapper({
   path = '',
   fileId = '',
   details = '',
+  hiddenShare = false,
   openWithDefaultAppQuery = 'true',
   openLinksWithDefaultApp = true
 } = {}) {
@@ -165,6 +188,10 @@ function getWrapper({
   )
 
   const mocks = { ...defaultComponentMocks() }
+  mocks.$clientService.owncloudSdk.shares.getShare.mockResolvedValue({
+    shareInfo: { hidden: hiddenShare ? 'true' : 'false' }
+  })
+
   const storeOptions = defaultStoreMockOptions
   const store = createStore(storeOptions)