Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut. No error message when opening a shortcut to a deleted resource #10315

Closed
ScharfViktor opened this issue Jan 9, 2024 · 2 comments
Closed
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ocis: 5.1.0-prealpha+465c9e3c20
web: 8.0.0-rc.1

when user opens shortcut for unshared resource or resource from disabled/deleted space he gets PROPFIND 404 but doesn't get any message on web

Steps:

  • create project space s1
  • in the personal space create shortcut to space s1
  • disable s1
  • try to open shortcut

Expected: to provide an error message like:
image

Actual: no message that resource not found. Only just a blank screen
Screenshot 2024-01-09 at 22 23 34

  1. Case with hidden shares:
  • admin shares file.txt to katherine
  • katherine creates shortcut for file.txt in personal space
  • katherine hides file.txt
  • katherine opens shortcut

Expect: not sure here. should we open text editor? or it works as expected

Actual: opened shares jail page

Screen.Recording.2024-01-09.at.22.41.09.mov
@ScharfViktor ScharfViktor added the Type:Bug Something isn't working label Jan 9, 2024
@JammingBen
Copy link
Collaborator

JammingBen commented Jan 10, 2024

Case 1 is definitely valid.

Case 2 is a known issue currently. Hidden shares should (and will) be accessible in the future, but we need to implement sharing NG first. I mixed it up with the sync status. A hidden share is accessible, so I'd expect the text editor to open still.

@JammingBen
Copy link
Collaborator

Fixed via #10321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants