fix: private link error messages and resolving hidden shares #10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
fix-private-link-error-messages
branch
2 times, most recently
from
b4b8d5f
to
ac2b08d
Compare
JammingBen
commented
Jan 15, 2024
JammingBen
force-pushed
the
fix-private-link-error-messages
branch
2 times, most recently
from
f529152
to
2427233
Compare
AlexAndBear
reviewed
Jan 16, 2024
JammingBen
force-pushed
the
fix-private-link-error-messages
branch
from
f07d5af
to
f8e5cf0
Compare
Co-authored-by: Jan <jan.alexander.ackermann@outlook.com>
JammingBen
force-pushed
the
fix-private-link-error-messages
branch
from
f8e5cf0
to
dbb5729
Compare
|
AlexAndBear
approved these changes
Jan 23, 2024
ownclouders
pushed a commit
that referenced
this pull request
Jan 24, 2024
fix: private link error messages and resolving hidden shares
ownclouders
pushed a commit
that referenced
this pull request
Jan 25, 2024
fix: private link error messages and resolving hidden shares
ownclouders
pushed a commit
that referenced
this pull request
Jan 26, 2024
fix: private link error messages and resolving hidden shares
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wrong and/or missing error messages when resolving private links as well as resolving into hidden shares. See the 2 commits for an easier understanding of the changes.
The error messaging for unaccepted (now "unsynced") shares assumed that there is a
resource, which is not the case. Therefore we can't distinguish between file or folder anymore, which is okay IMO since unsynced shares will be accessible in the near future. That means these code paths will be removed soon.Related Issue
Types of changes