Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a key to theme for a logo in the theme JSON #3782

Closed
LukasHirt opened this issue Jul 15, 2020 · 0 comments · Fixed by #3783
Closed

Add a key to theme for a logo in the theme JSON #3782

LukasHirt opened this issue Jul 15, 2020 · 0 comments · Fixed by #3783
Projects
oCIS Sprint 20-14

Comments

@LukasHirt
Copy link
Contributor

The current implementation loads the logo via the theme name which forces the theme creator to put the logo in a specific location and forces to use only SVG format. Adding a key into the theme JSON would enable then the logo to live in different locations and also different formats.
@LukasHirt LukasHirt added this to Sprint Backlog in oCIS Sprint 20-14 via automation Jul 15, 2020
@LukasHirt LukasHirt moved this from Sprint Backlog to Input Next Sprint in oCIS Sprint 20-14 Jul 15, 2020
@LukasHirt LukasHirt mentioned this issue Jul 15, 2020
Merged
5 tasks
@LukasHirt LukasHirt moved this from Input Next Sprint to In progress in oCIS Sprint 20-14 Jul 15, 2020
oCIS Sprint 20-14 automation moved this from In progress to Done Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
oCIS Sprint 20-14
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add key to theme for sidebar logo owncloud/web
1 participant
@LukasHirt