Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key to theme for sidebar logo #3783

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

LukasHirt
Copy link
Contributor

Description

We've added a key into the theme which enables using a different logo in the sidebar.

Related Issue

How Has This Been Tested?

Define a different logo and see it being changed in the sidebar

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jul 15, 2020
@LukasHirt LukasHirt self-assigned this Jul 15, 2020
@LukasHirt LukasHirt added this to To review in oCIS Sprint 20-14 Jul 15, 2020
oCIS Sprint 20-14 automation moved this from To review to In progress Jul 15, 2020
@LukasHirt
Copy link
Contributor Author

As a bonus in this PR - removed the theme folder inside of the src folder.

@LukasHirt LukasHirt moved this from In progress to To review in oCIS Sprint 20-14 Jul 15, 2020
@LukasHirt LukasHirt merged commit d067883 into master Jul 16, 2020
oCIS Sprint 20-14 automation moved this from To review to Done Jul 16, 2020
@LukasHirt LukasHirt deleted the feature/themeable-sidebar-logo branch July 16, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add a key to theme for a logo in the theme JSON
2 participants