Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-runtime depends on Files/ store namespace #5357

Closed
dschmidt opened this issue Jun 23, 2021 · 1 comment
Closed

web-runtime depends on Files/ store namespace #5357

dschmidt opened this issue Jun 23, 2021 · 1 comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working Type:Technical-Debt

Comments

@dschmidt
Copy link
Member

Screenshot_20210623_201158

The problem seems to be in this line:

...mapGetters('Files', ['publicLinkPassword']),

web-runtime probably should not depend on the files app's store.
A few lines later actions from Files/ are mapped too. That doesn't lead to such errors on startup but it is probably not a good idea either :)

Steps to reproduce

  1. Load oC Web without files app
  2. See errors in console

Expected behaviour

No errors appear

Actual behaviour

Errors appear

@kulmann kulmann added this to Todo - Features in Web Support Board via automation Dec 3, 2021
@kulmann kulmann moved this from Todo - Features to Todo - Bugs in Web Support Board Dec 3, 2021
@kulmann kulmann added the Priority:p3-medium Normal priority label Dec 3, 2021
@pascalwengerter pascalwengerter moved this from Bugs Prio 3 or less to Refactor / Tech debt in Web Support Board May 24, 2022
@dschmidt
Copy link
Member Author

publicLinkPassword handling has been moved to runtime and in the linked file I don't see any references to Files/ anymore. Needs further checking but can be potentially closed

Web Support Board automation moved this from Refactor / Tech debt to Done Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working Type:Technical-Debt
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants