Release 5.0.0 #6248

pascalwengerter · 2022-01-13T11:44:02Z

Waiting for

If time permits

Small optional fixes / wishes (maybe on release branch)

checkboxes have no focus border anymore
left sidebar toggle "expand" is not visible anymore (collapsed mode) Add missing changelog items, fix UI glitches, supersede dependabot PRs #6386
left sidebar nav items have white padding on the right (collapsed mode) Add missing changelog items, fix UI glitches, supersede dependabot PRs #6386

Release checklist

The text was updated successfully, but these errors were encountered:

dschmidt · 2022-01-14T22:28:53Z

I would really like to see #6156 getting into the release. I made sure to make it readytoreview before my vacation because file/folder handling inconsistencies in different apps have superannoying consequences like certain apps only working in certain contexts... and we need this pr to properly fix it for all apps

kulmann · 2022-02-10T21:37:29Z

There's a regression on current master that prevents public links with password to be loaded from ownCloud 10 backends. Currently investigating...

Propfind for a public link with password gives the following error message:

<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns"<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAVACL\Exception\NeedPrivileges</s:exception>
  <s:message>User did not have the required privileges ({DAV:}read) for path "public-files/2iYEtDt3MhwfcoI"</s:message>
  <d:need-privileges>
    <d:resource>
      <d:href>/remote.php/dav/public-files/2iYEtDt3MhwfcoI</d:href>
      <d:privilege>
        <d:read/>
      </d:privilege>
    </d:resource>
  </d:need-privileges>
</d:error>

for a request URL like this: http://host.docker.internal:8080/remote.php/dav/public-files/2iYEtDt3MhwfcoI

dschmidt · 2022-02-10T22:45:20Z

owncloud/core#39707

pascalwengerter · 2022-02-11T12:48:29Z

Smoke testing oCIS 1.16 with the WOPI deployment example (edge has broken the WOPI integration AFAIK) and the v5.0.0 leads to certification errors (we used to prevent them by visiting the editor URL, e.g. codimd.owncloud.test, and choosing the "accept the risk and continue" button before opening the editor, which doesn't seem to work anymore) false alarm, works as expected. No clue what caused the hickup (perhaps hadn't fully started the necessary services yet?)

ScharfViktor · 2022-02-11T14:00:49Z

SmokeTest against ocis

branch: v5.0.0-rc

Case 1: admin share folder(with file) to marie:

Admin:

upload big file 30gb - very slow
upload big file 10gb - very slow
upload folder with 848 files.
Check pagination, count items per page.
❌ - [ ] upload folder(drag folder) "folder_to_share" with file.pdf Bug: Upload folder (drag and drop) doesn't work #6426
share folder "folder_to_share" to marie with edit right

Marie:

accept "folder_to_share"
❌ - when you try to rename file before accept you get 404 Error. Which I think is right. Do we need button "rename"?
rename "folder_to_share" (?admin don't see)
upload new file "file.txt" to "folder_to_share" (admin see new file)
open pdf file
rename file.pdf (use rigth click) (admin see that file changed name)
try to move "folder_to_share" to "/" (501 not implement)
copy "folder_to_share" to "/"

Admin:

add new file.jpeg to "folder_to_share" (marie can see file without access)
add file format drawio(marie can open in Draw.io and can edit)
move file.pdf to "/" (marie can not see file.pdf)
add new "file.txt" create new version. (marie can see new version)
open txt file in markdown-editor. Change and save.
Marie:
can download both versions (!error 501)
restore old version

Admin:

change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

decline folder

Admin:

delete folder "folder_to_share" (marie: folder Shares empty)

Case 2: admin share file to marie:

Admin:

upload file.jpeg
share file.jpeg to marie with rigth viewer (use main menu. find marie by email marie@example.org)

Marie:

accept file (marie can open/download/copy file but cannot delete/move/rename)
copy file to "/"
open file in Mediaviewer
download file

Admin:

change share "file.jpeg" from "viewer" to "edit"(marie can open/download/copy/rename file)

Marie:

rename file (admin don't see)

Admin:

unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:

Case 4: admin create link to file

Admin:

Case 5: create new user:

Admin:

create new account "tom"

Tom:
❌ - [ ] go to account #6430

change language

Admin:

block user (Login Error access denied)
delete user (Logon failed)
logout

Findings:

The "Accounts" tab is not available The "Accounts" tab is not available #6430
Change role in public link doesn't work Public link. Change role doesn't work #6429
Archiver doesn't work in public link Archiver in the public link doesn't work #6423
Upload folder via drag and drop is broken Upload folder (drag and drop) doesn't work #6426

kulmann · 2022-02-11T14:56:01Z

Smoke test v5.0.0-rc against oc10 app

✔️ as gunter - upload arch/mips folder from linux kernel (1945 files)
- ❌ drag and drop folder upload completely broken 👎 error the server responded with a status of 403 (Forbidden)
- via folder upload button works
- progress bar is not sticky
- expanding the upload progress section slows down browser & upload time significantly
✔️ as gunter - share the folder to alice as viewer
- sharing is not possible before the upload finished (user invite field doesn't stay focussed)
- ❌ for reaching the invite form field one needs to tab through the whole file list until the sidebar is reached (focus should be set to sidebar or sidebar panel instead, depending on a11y needs)
✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)
✔️ as alice - try do delete file from shared folder
- individual delete action not visible, good
- batch delete action not visible, good
- context menu action not visible, good
✔️ as alice - try to add file
- not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.
❌ as alice - copy 16 folders from share to home
- no visible feedback that it's in progress
- UI still weirdly usable, ended up in an active upload drop zone. Needed a page reload to be usable again.
- folder listing after copy shows ? as folder size on some of the copied folders.
✔️ as gunter - add new file to share
✔️ as alice - receive new file in existing share
✔️ as gunter - unshare folder from shared with others
✔️ as alice - try to revisit old share
- shows resource not found upon page reload, good
- going back to All files or Shared with me doesn't list the share anymore, good
✔️ as gunter - share folder with alice again, but as editor
- setting and removing an expiration date work as expected, good
✔️ as alice - rename file
- via right sidebar, works, good
- via context menu, works, good
✔️ as gunter - add file
✔️ as alice - delete file
- via right sidebar, works, good
- via context menu, works, good
- via batch action, works, good
✔️ as alice - create public link on any folder
✔️ as alice delete file and recover it
✔️ as alice create version of textfile
✔️ as alice view version history of text file
✔️ as alice download newest version of text file
✔️ download older version of text file
✔️ restore older version of text file
- no visible feedback about the success
- preview is not updated
✔️ as alice - upload avatar in classic UI
- see own avatar in top bar (far right)
- login as gunter, having a share with alice
  - shared with others page loads and shows avatars
- avatar in top bar doesn't have correct aspect ratio, see screenshot

✔️ as alice, move a file into subfolder via drag and drop
✔️ as alice, move multiple files & folders into subfolder via drag and drop
✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

Findings from old smoke testing:

❌ when a share fails, the submit button of the form stays in the disabled state with spinner. Needs to reset itself instead. (not resolved yet!)

Findings from new smoke testing:

❌ avatar in top bar doesn't have correct aspect ratio, see screenshot (solved)

❌ drag and drop folder upload completely broken (solved)
❌ (error) messages in modal are centered instead of left aligned (introduced by me in views/PublicLink.vue), see screenshot (solved)

ChrisEdS · 2022-02-11T16:08:38Z

Settings menu placement looks wrong:

Reduce at least the spacing to the gear icon?

pascalwengerter · 2022-02-11T16:32:17Z

Settings menu placement looks wrong:

Reduce at least the spacing to the gear icon?

@kulmann that was introduced by giving the .tippy-content additional padding to make the shadow visible 🥴

pascalwengerter · 2022-02-11T16:35:49Z

I have a fix for the avatar image width/height mess-up. ~~Push straight to release branch?~~ Pushed to the release branch

kulmann · 2022-02-11T17:12:36Z

I have a fix for the avatar image width/height mess-up. Push straight to release branch?

Yep, push it :-)

ChrisEdS · 2022-02-13T21:15:09Z

Low contrast in folder action menu

kulmann · 2022-02-14T15:10:07Z

Dark mode search preview has the same background color and parent-folder link color, see screenshot

pascalwengerter · 2022-02-14T15:41:52Z

SmokeTest against oCIS (binary @ current master)

branch: release-5.0.0

Case 1: admin share folder(with file) to marie:

einstein:

upload big file 30gb - very slow
upload big file 6.6gb - reasonably fast
upload folder with 848 files.
Check pagination, count items per page.
upload folder via drag&drop (7.111 files) - progress bar doesn't move while count goes from 1 to 7.111, then does track progress while counting down again. Upload interupted by OIDC refresh
share folder "101_archive to marie with edit right

Marie:

accept "101_archive"
❌ when trying to rename file before accept you get 404 Error. => we should not show the rename action on pending shares (folders)
rename "101_archive" to "archive_2" works for Marie, but doesn't show renamed folder for einstein
upload new file "file.txt" to "101_archive", is visible for einstein
open pdf file
rename file in "archive_2", einstein sees that file has been renamed
try to move "101_archive" to "user home" (leads to error message)
copy "101_archive" to "user home" (no visible feedback for copying this many files, browser session is totally wrecked after trying to navigate into copied folder which has only partly copied files)

Einstein:

add new file.jpeg to "101_archive" (marie can see file)
add file format drawio (marie can open in Draw.io and can edit)
move file.pdf to "/" (marie can not see file.pdf)
add new "file.txt" create new version. (marie can see new version)
open txt file in markdown-editor. Change and save.

Marie:

❌ can download both versions (!error 501)
❌ restore old version toggles between two older states

Einstein:

change share "101_archive" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

decline folder

Einstein:

delete folder "folder_to_share" (marie: folder Shares empty)

Case 2: admin share file to marie:

Einstein:

upload file.jpeg
share file.jpeg to marie with viewer permissions

Marie:

accept file (marie can open/download/copy file but cannot delete/move/rename)
copy file to "/"
open file in Mediaviewer
download file

Einstein:

rename "file.jpeg" to "file2.jpeg", marie doesn't see renamed share but original filename "file.jpeg"
change share permissions for "file2.jpeg" from "viewer" to "edit"(marie can open/download/copy/rename file)

Marie:

rename file to "file3.jpg", einstein doesn't see renamed share but original filename "file2.jpeg"

Einstein:

unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: einstein create public links to folder

einstein:

Case 4: einstein create link to file

einstein:

Case 5: create new user:

Admin:

❌ create new account "tom"

Tom:

❌ go to account The "Accounts" tab is not available #6430
❌ change language

Admin:

❌ block user (Login Error access denied)
❌ delete user (Logon failed)
❌ logout

Findings:

The "Accounts" tab is not available The "Accounts" tab is not available #6430
~~Change role in public link doesn't work Public link. Change role doesn't work #6429~~
Archiver doesn't work in public link Archiver in the public link doesn't work #6423 (no capabilities on password protected public link, archiver returns 404 on non-password protected public link)
~~Upload folder via drag and drop is broken Upload folder (drag and drop) doesn't work #6426~~

ChrisEdS · 2022-02-14T16:19:30Z

Jumping file list content in small resolution

Screen.Recording.2022-02-14.at.17.16.49.mov

pascalwengerter pinned this issue Jan 13, 2022

wkloucek mentioned this issue Feb 9, 2022

Release 1.17.0 Tech Preview owncloud/ocis#2998

Closed

22 tasks

fschade mentioned this issue Feb 9, 2022

[full-ci] Enforce extensions to always display the ui-header #6401

Merged

4 tasks

kulmann mentioned this issue Feb 11, 2022

Release 5.0.0 #6424

Merged

This comment was marked as off-topic.

Sign in to view

This comment was marked as outdated.

Sign in to view

kulmann closed this as completed in #6424 Feb 15, 2022

pascalwengerter unpinned this issue Feb 15, 2022

dschmidt mentioned this issue Feb 16, 2022

PROPFIND on (password protected) public link returns invalid XML owncloud/core#39707

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 5.0.0 #6248

Release 5.0.0 #6248

pascalwengerter commented Jan 13, 2022 •

edited by kulmann

dschmidt commented Jan 14, 2022

kulmann commented Feb 10, 2022 •

edited

dschmidt commented Feb 10, 2022

pascalwengerter commented Feb 11, 2022 •

edited

ScharfViktor commented Feb 11, 2022 •

edited

kulmann commented Feb 11, 2022 •

edited

ChrisEdS commented Feb 11, 2022

pascalwengerter commented Feb 11, 2022

pascalwengerter commented Feb 11, 2022 •

edited

kulmann commented Feb 11, 2022

ChrisEdS commented Feb 13, 2022

This comment was marked as off-topic.

This comment was marked as outdated.

This comment was marked as outdated.

kulmann commented Feb 14, 2022

pascalwengerter commented Feb 14, 2022

ChrisEdS commented Feb 14, 2022

Release 5.0.0 #6248

Release 5.0.0 #6248

Comments

pascalwengerter commented Jan 13, 2022 • edited by kulmann

Waiting for

If time permits

Small optional fixes / wishes (maybe on release branch)

Release checklist

dschmidt commented Jan 14, 2022

kulmann commented Feb 10, 2022 • edited

dschmidt commented Feb 10, 2022

pascalwengerter commented Feb 11, 2022 • edited

ScharfViktor commented Feb 11, 2022 • edited

SmokeTest against ocis

Case 1: admin share folder(with file) to marie:

Case 2: admin share file to marie:

Case 3: admin create public links to folder

Case 4: admin create link to file

Case 5: create new user:

Findings:

kulmann commented Feb 11, 2022 • edited

Smoke test v5.0.0-rc against oc10 app

Findings from old smoke testing:

Findings from new smoke testing:

ChrisEdS commented Feb 11, 2022

pascalwengerter commented Feb 11, 2022

pascalwengerter commented Feb 11, 2022 • edited

kulmann commented Feb 11, 2022

ChrisEdS commented Feb 13, 2022

This comment was marked as off-topic.

This comment was marked as outdated.

This comment was marked as outdated.

kulmann commented Feb 14, 2022

pascalwengerter commented Feb 14, 2022

SmokeTest against oCIS (binary @ current master)

Case 1: admin share folder(with file) to marie:

Case 2: admin share file to marie:

Case 3: einstein create public links to folder

Case 4: einstein create link to file

Case 5: create new user:

Findings:

ChrisEdS commented Feb 14, 2022

pascalwengerter commented Jan 13, 2022 •

edited by kulmann

kulmann commented Feb 10, 2022 •

edited

pascalwengerter commented Feb 11, 2022 •

edited

ScharfViktor commented Feb 11, 2022 •

edited

kulmann commented Feb 11, 2022 •

edited

pascalwengerter commented Feb 11, 2022 •

edited