Don't show file extensions in AppTopBar and Search if turned off via setting #10176
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
changelog/unreleased/bugfix-turned-off-file-extensions-had-no-effect
Outdated
Show resolved
Hide resolved
changelog/unreleased/bugfix-turned-off-file-extensions-had-no-effect
Outdated
Show resolved
Hide resolved
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
changelog/unreleased/bugfix-turned-off-file-extensions-had-no-effect
Outdated
Show resolved
Hide resolved
| false | ||
| ) | ||
|
|
||
| expect(wrapper.html()).toMatchSnapshot() |
There was a problem hiding this comment.
Could you check instead that the displayed file name matches test instead of test.txt? You're testing one very specific detail, I'd like to avoid to throw a snapshot test at that.
There was a problem hiding this comment.
the whole tests are snapshot tests, I don't wanted to interfere here,
if you want me to change that, please say yes and I will follow, my team lead 👍
There was a problem hiding this comment.
hmmm ok, then do it with the snapshot test. I'll make it part of the unit test improvement initiative 😁
There was a problem hiding this comment.
I'll be sick on the unit test improvement initiative :(
packages/web-pkg/tests/unit/components/Search/ResourcePreview.spec.ts
Outdated
Show resolved
Hide resolved
…effect Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
|
delete-merged-branch
bot
deleted the
fix-file-extensions-shown-even-if-settings-is-off
branch
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: