refactor: remove deprecated extension point for adding quick actions

changelog/unreleased/change-remove-deprecated-quick-actions-extension-point

@@ -0,0 +1,6 @@
+Change: Remove deprecated extension point for adding quick actions
+
+BREAKING CHANGE for developers: The old way of registering quick actions via the `quickaction` property of an app has been removed. Quick actions should be registered as extension via our extension registry. They need to be of type `action` and have the `files.quick-action` scope.
+
+https://github.com/owncloud/web/pull/10102
+https://github.com/owncloud/web/pull/10223

packages/web-app-files/tests/__fixtures__/fileActions.ts

@@ -56,27 +56,13 @@ export const editors = [
   }
 ]
 
-const sideBars = [
-  {
-    app: 'details',
-    enabled: jest.fn(),
-    icon: 'information'
-  },
-  {
-    app: 'actions',
-    enabled: jest.fn(),
-    icon: 'information'
-  }
-]
-
 export const apps = {
   customFileListIndicators: [],
   file: {
     edit: false,
     path: ''
   },
   fileEditors: editors,
-  fileSideBars: sideBars,
   newFileHandlers: editors,
   meta
 }

packages/web-pkg/src/apps/types.ts

@@ -39,15 +39,6 @@ export interface ApplicationQuickAction {
   displayed?: (...args) => boolean | boolean
 }
 
-/**
- * ApplicationQuickActions describes a map of application actions that are used in the runtime
- *
- * @deprecated Quick actions should be registered as extension via the `files.quick-action` scope.
- */
-export interface ApplicationQuickActions {
-  [key: string]: ApplicationQuickAction
-}
-
 export type AppConfigObject = Record<string, any>
 
 export interface ApplicationMenuItem {
@@ -64,7 +55,6 @@ export interface ApplicationInformation {
   isFileEditor?: boolean
   extensions?: any[]
   defaultExtension?: string
-  fileSideBars?: any[]
   applicationMenu?: ApplicationMenuItem
 }
 
@@ -83,8 +73,6 @@ export interface ClassicApplicationScript {
   store?: Module<unknown, unknown>
   routes?: ((...args) => RouteRecordRaw[]) | RouteRecordRaw[]
   navItems?: ((...args) => AppNavigationItem[]) | AppNavigationItem[]
-  /** @deprecated Quick actions should be registered as extension via the `files.quick-action` scope. */
-  quickActions?: ApplicationQuickActions
   translations?: ApplicationTranslations
   extensions?: Ref<Extension[]>
   initialize?: () => void

packages/web-runtime/src/container/api.ts

@@ -5,11 +5,7 @@ import { ApiError } from '@ownclouders/web-pkg'
 import { get, isEqual, isObject, isArray, merge } from 'lodash-es'
 import { Module, Store } from 'vuex'
 import { App, Component, h } from 'vue'
-import {
-  ApplicationQuickActions,
-  ApplicationTranslations,
-  AppNavigationItem
-} from '@ownclouders/web-pkg'
+import { ApplicationTranslations, AppNavigationItem } from '@ownclouders/web-pkg'
 import type { Language } from 'vue3-gettext'
 
 /**
@@ -121,23 +117,6 @@ const announceTranslations = (
   })
 }
 
-/**
- * inject application specific quickActions into runtime
- *
- * @param store
- * @param quickActions
- */
-const announceQuickActions = (
-  store: Store<unknown>,
-  quickActions: ApplicationQuickActions
-): void => {
-  if (!isObject(quickActions)) {
-    throw new ApiError("quickActions can't be blank")
-  }
-
-  store.commit('ADD_QUICK_ACTIONS', quickActions)
-}
-
 /**
  * inject application specific store into runtime
  *
@@ -258,8 +237,6 @@ export const buildRuntimeApi = ({
       announceNavigationItems(applicationId, store, navigationItems),
     announceTranslations: (appTranslations: ApplicationTranslations): void =>
       announceTranslations(supportedLanguages, gettext, appTranslations),
-    announceQuickActions: (quickActions: ApplicationQuickActions): void =>
-      announceQuickActions(store, quickActions),
     announceStore: (applicationStore: Module<unknown, unknown>): void =>
       announceStore(applicationName, store, applicationStore),
     announceExtension: (extension: { [key: string]: unknown }): void =>

packages/web-runtime/src/container/application/classic.ts

@@ -25,15 +25,14 @@ class ClassicApplication extends NextApplication {
   }
 
   initialize(): Promise<void> {
-    const { routes, navItems, translations, quickActions, store } = this.applicationScript
+    const { routes, navItems, translations, store } = this.applicationScript
     const { globalProperties } = this.app.config
     const _routes = typeof routes === 'function' ? routes(globalProperties) : routes
     const _navItems = typeof navItems === 'function' ? navItems(globalProperties) : navItems
 
     routes && this.runtimeApi.announceRoutes(_routes)
     navItems && this.runtimeApi.announceNavigationItems(_navItems)
     translations && this.runtimeApi.announceTranslations(translations)
-    quickActions && this.runtimeApi.announceQuickActions(quickActions)
     store && this.runtimeApi.announceStore(store)
 
     return Promise.resolve(undefined)

packages/web-runtime/src/container/types.ts

@@ -1,11 +1,7 @@
 import { Module, Store } from 'vuex'
 import { Router, RouteRecordRaw } from 'vue-router'
 import { App, Component } from 'vue'
-import {
-  AppNavigationItem,
-  ApplicationQuickActions,
-  ApplicationTranslations
-} from '@ownclouders/web-pkg'
+import { AppNavigationItem, ApplicationTranslations } from '@ownclouders/web-pkg'
 
 /** shim configuration for now, should be typed in a later step */
 export type RuntimeConfiguration = any
@@ -15,7 +11,6 @@ export interface RuntimeApi {
   announceRoutes: (routes: RouteRecordRaw[]) => void
   announceNavigationItems: (navigationItems: AppNavigationItem[]) => void
   announceTranslations: (appTranslations: ApplicationTranslations) => void
-  announceQuickActions: (quickActions: ApplicationQuickActions) => void
   announceStore: (applicationStore: Module<unknown, unknown>) => void
   announceExtension: (extension: { [key: string]: unknown }) => void
   requestStore: () => Store<unknown>

packages/web-runtime/src/store/app.ts

@@ -1,6 +1,5 @@
 const state = {
-  messages: [],
-  quickActions: {}
+  messages: []
 }
 
 const actions = {
@@ -58,9 +57,6 @@ const mutations = {
   },
   REMOVE_MESSAGE(state, item) {
     state.messages.splice(state.messages.indexOf(item), 1)
-  },
-  ADD_QUICK_ACTIONS(state, quickActions) {
-    state.quickActions = Object.assign(state.quickActions, quickActions)
   }
 }
 

packages/web-test-helpers/src/mocks/store/defaultStoreMockOptions.ts

@@ -26,9 +26,6 @@ export const defaultStoreMockOptions = {
       state: {
         fileEditors: [],
         meta: {}
-      },
-      getters: {
-        fileSideBars: jest.fn(() => [])
       }
     },
     External: {