Bugfix: Readonly user attributes have no effect on group memberships

changelog/unreleased/bugfix-read-only-user-attributes-have-no-effect-on-group-memberships

@@ -0,0 +1,6 @@
+Bugfix: Readonly user attributes have no effect on group memberships
+
+We've fixed a bug where the entity 'user.memberOf' set via env var `FRONTEND_READONLY_USER_ATTRIBUTES`
+had no effect.
+
+https://github.com/owncloud/web/pull/10347

packages/web-app-admin-settings/src/components/Users/GroupSelect.vue

@@ -8,6 +8,7 @@
       option-label="displayName"
       :label="$gettext('Groups')"
       :fix-message-line="true"
+      v-bind="$attrs"
       @update:model-value="onUpdate"
     >
       <template #selected-option="{ displayName, id }">

packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue

@@ -91,6 +91,7 @@
         />
         <group-select
           class="oc-mb-s"
+          :read-only="isInputFieldReadOnly('user.memberOf')"
           :selected-groups="editUser.memberOf"
           :group-options="groupOptions"
           @selected-option-change="changeSelectedGroupOption"

packages/web-app-admin-settings/src/composables/actions/users/useUserActionsAddToGroups.ts

@@ -1,12 +1,13 @@
 import { computed, Ref, unref } from 'vue'
 import { useGettext } from 'vue3-gettext'
-import { UserAction, useStore } from '@ownclouders/web-pkg'
+import { useCapabilityReadOnlyUserAttributes, UserAction, useStore } from '@ownclouders/web-pkg'
 import { Group } from '@ownclouders/web-client/src/generated'
 import AddToGroupsModal from '../../../components/Users/AddToGroupsModal.vue'
 
 export const useUserActionsAddToGroups = ({ groups }: { groups: Ref<Group[]> }) => {
   const store = useStore()
   const { $gettext, $ngettext } = useGettext()
+  const readOnlyUserAttributes = useCapabilityReadOnlyUserAttributes()
 
   const handler = ({ resources }) => {
     return store.dispatch('createModal', {
@@ -36,7 +37,13 @@ export const useUserActionsAddToGroups = ({ groups }: { groups: Ref<Group[]> })
       componentType: 'button',
       class: 'oc-users-actions-add-to-groups-trigger',
       label: () => $gettext('Add to groups'),
-      isEnabled: ({ resources }) => resources.length > 0,
+      isEnabled: ({ resources }) => {
+        if (unref(readOnlyUserAttributes).includes('user.memberOf')) {
+          return false
+        }
+
+        return resources.length > 0
+      },
       handler
     }
   ])

packages/web-app-admin-settings/src/composables/actions/users/useUserActionsRemoveFromGroups.ts

@@ -1,12 +1,13 @@
 import { computed, Ref, unref } from 'vue'
 import { useGettext } from 'vue3-gettext'
-import { UserAction, useStore } from '@ownclouders/web-pkg'
+import { useCapabilityReadOnlyUserAttributes, UserAction, useStore } from '@ownclouders/web-pkg'
 import { Group } from '@ownclouders/web-client/src/generated'
 import RemoveFromGroupsModal from '../../../components/Users/RemoveFromGroupsModal.vue'
 
 export const useUserActionsRemoveFromGroups = ({ groups }: { groups: Ref<Group[]> }) => {
   const store = useStore()
   const { $gettext, $ngettext } = useGettext()
+  const readOnlyUserAttributes = useCapabilityReadOnlyUserAttributes()
 
   const handler = ({ resources }) => {
     return store.dispatch('createModal', {
@@ -36,7 +37,13 @@ export const useUserActionsRemoveFromGroups = ({ groups }: { groups: Ref<Group[]
       componentType: 'button',
       class: 'oc-users-actions-remove-from-groups-trigger',
       label: () => $gettext('Remove from groups'),
-      isEnabled: ({ resources }) => resources.length > 0,
+      isEnabled: ({ resources }) => {
+        if (unref(readOnlyUserAttributes).includes('user.memberOf')) {
+          return false
+        }
+
+        return resources.length > 0
+      },
       handler
     }
   ])

packages/web-app-admin-settings/tests/unit/components/Users/SideBar/__snapshots__/EditPanel.spec.ts.snap

@@ -18,7 +18,7 @@ exports[`EditPanel renders all available inputs 1`] = `
         <div class="oc-text-input-message"></div>
       </div>
       <quota-select-stub class="oc-mb-s" description-message="" disabled="false" fix-message-line="true" id="quota-select-form" label="Personal quota" maxquota="0" read-only="false" totalquota="0"></quota-select-stub>
-      <group-select-stub class="oc-mb-s" groupoptions="undefined,undefined" selectedgroups=""></group-select-stub>
+      <group-select-stub class="oc-mb-s" groupoptions="undefined,undefined" read-only="false" selectedgroups=""></group-select-stub>
     </div>
     <compare-save-dialog-stub class="edit-compare-save-dialog oc-mb-l" compareobject="[object Object]" confirmbuttondisabled="false" originalobject="[object Object]"></compare-save-dialog-stub>
   </form>

packages/web-app-admin-settings/tests/unit/composables/actions/users/useUserActionsAddToGroups.spec.ts

@@ -17,6 +17,19 @@ describe('useUserActionsAddToGroups', () => {
         }
       })
     })
+    it('returns false if included in capability readOnlyUserAttributes list', () => {
+      getWrapper({
+        setup: ({ actions }, { storeOptions }) => {
+          storeOptions.getters.capabilities.mockReturnValue({
+            graph: {
+              users: { read_only_attributes: ['user.memberOf'] }
+            }
+          })
+
+          expect(unref(actions)[0].isEnabled({ resources: [mock<User>()] })).toEqual(false)
+        }
+      })
+    })
   })
   describe('method "handler"', () => {
     it('creates a modal', () => {

packages/web-app-admin-settings/tests/unit/composables/actions/users/useUserActionsRemoveFromGroups.spec.ts

@@ -17,6 +17,19 @@ describe('useUserActionsRemoveFromGroups', () => {
         }
       })
     })
+    it('returns false if included in capability readOnlyUserAttributes list', () => {
+      getWrapper({
+        setup: ({ actions }, { storeOptions }) => {
+          storeOptions.getters.capabilities.mockReturnValue({
+            graph: {
+              users: { read_only_attributes: ['user.memberOf'] }
+            }
+          })
+
+          expect(unref(actions)[0].isEnabled({ resources: [mock<User>()] })).toEqual(false)
+        }
+      })
+    })
   })
   describe('method "handler"', () => {
     it('creates a modal', () => {