feat: adjust tile sizes

[kulmann]

Description

Played around with tile sizes... stepping from one tile size to the next was too big.

Previously we had 9rem as base tile size and added 9rem for every step in the tile size slider.
Now we have 10rem as base tile size and add 6rem for every step in the tile size slider.

Related Issue

• Fixes Increase standard tile size #10018
• Fixes Tile size switch misbehaving  #10564

Screenshots:

new default tile size (the second stepping, slighty smaller than before: now 16rem, before 18rem)

new smallest tile size (the first stepping, slightly bigger than before: now 10rem, before 9rem)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests
• Documentation
• Maintenance (e.g. dependency updates or tooling)

[AlexAndBear]

IHMO we should also limit the max tile size. It's too big to make sense

[kulmann]

IHMO we should also limit the max tile size. It's too big to make sense

you mean the design tokens / css vars? base size and step size? what do you think are reasonable values? Steps are limited to 6, i.e. with the defaults that we now have in the design tokens the max tile size is 10rem + (5 * 6rem) = 40rem, which should be ok.

[AlexAndBear]

If I have 3 spaces on the board and set the tile size to max, it looks like this:

Which I think looks ridiculous :(

[kulmann]

If I have 3 spaces on the board and set the tile size to max, it looks like this:
Which I think looks ridiculous :(

As long as that's not your only option to display space tiles at all... I don't see the issue honestly.

[AlexAndBear]

Yeah I found the issue. In the spaces view it renders 1 tile in the same display resolution and tile size setting and in the personal/files view it renders 2 tiles. There is also an issue with the tile size stays the same just the inner icon size changes on smaller screens between some tiles view size steps 🤷‍♀️

Feels a little inconsistent overall but maybe scope creep

[kulmann]

Yeah I found the issue. In the spaces view it renders 1 tile in the same display resolution and tile size setting and in the personal/files view it renders 2 tiles. There is also an issue with the tile size stays the same just the inner icon size changes on smaller screens between some tiles view size steps 🤷‍♀️

Feels a little inconsistent overall but maybe scope creep

uh... sounds worth fixing. can you provide detailed steps to reproduce? then I can tackle it in this PR as well maybe.

[JammingBen]

LGTM (aside from the issues Alex was mentioning) 👍

[kulmann]

Yeah I found the issue. In the spaces view it renders 1 tile in the same display resolution and tile size setting and in the personal/files view it renders 2 tiles. There is also an issue with the tile size stays the same just the inner icon size changes on smaller screens between some tiles view size steps 🤷‍♀️

Feels a little inconsistent overall but maybe scope creep

Fixed :-)

[AlexAndBear]

Unfortunately not for me :( icons are not resizing anymore, but as well tiles stay the same size

Screen.Recording.2024-03-12.at.20.37.47.mov

[kulmann]

@AlexAndBear could you please test again? :-) slider max value now gets adjusted according to max available steps calculated in the tiles view.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[AlexAndBear]

I love it ! 😮