Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: theme loading when no matching theme found #10659

Merged
merged 2 commits into from
Mar 22, 2024
Merged

fix: theme loading when no matching theme found #10659

merged 2 commits into from
Mar 22, 2024

Conversation

JammingBen
Copy link
Collaborator

Description

Fixes theme loading when no matching theme for the current OS settings is found.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen
fix: theme loading when no matching theme found
a68a41c 
Fixes theme loading when no matching theme for the current OS settings is found.
@JammingBen JammingBen self-assigned this Mar 21, 2024
@JammingBen JammingBen requested a review from kulmann March 22, 2024 07:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kulmann
kulmann approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@JammingBen JammingBen merged commit a48dd86 into stable-8.0 Mar 22, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-theme-loading branch March 22, 2024 08:21
@JammingBen JammingBen mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JammingBen @kulmann @AlexAndBear