[test-only]use universal ctrl-meta modifier #11025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
2403905
approved these changes
Jun 11, 2024
saw-jan
approved these changes
Jun 11, 2024
ScharfViktor
force-pushed
the
useUniversalCtrlMetaModifier1
branch
from
8a949d8
to
01b8a64
Compare
ScharfViktor
force-pushed
the
useUniversalCtrlMetaModifier1
branch
from
01b8a64
to
70a896a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
page.keyboard.press('Control+A') didn't work on macOs, so we had to change it to page.keyboard.press('Meta+A') to run locally.
This has been fixed in the latest version, so now we can use it like await page.keyboard.press('ControlOrMeta+A')